Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Status" to "Flag" in the class names #73

Closed
lachmanfrantisek opened this issue May 29, 2019 · 2 comments · Fixed by #118
Closed

Change "Status" to "Flag" in the class names #73

lachmanfrantisek opened this issue May 29, 2019 · 2 comments · Fixed by #118
Labels
good-first-issue Good for newcomers. kind/technical-debt The code needs love. Refactoring.

Comments

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented May 29, 2019 •
edited by jpopelka
Loading

What about changing CommitStatus/PullRequestStatus to CommitFlag/PullRequestFlag?

Original discussion: #71 (review)
@lachmanfrantisek lachmanfrantisek mentioned this issue May 29, 2019
Merged
2 tasks
@lachmanfrantisek lachmanfrantisek added kind/technical-debt The code needs love. Refactoring. and removed refactoring labels Jul 2, 2019
@lbarcziova lbarcziova mentioned this issue Jul 15, 2019
Merged
@jpopelka
Copy link
Member

There's also IssueStatus? (just spotted it in user-cont/release-bot#231)
Should we change IssueStatus to IssueFlag as well?

@lachmanfrantisek
Copy link
Member Author

lachmanfrantisek commented Jul 16, 2019 •
edited
Loading

There's also IssueStatus? (just spotted it in user-cont/release-bot#231)
Should we change IssueStatus to IssueFlag as well?

Good point, we've missed two things together:

  • status: open/close
  • flag: CI status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers. kind/technical-debt The code needs love. Refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CommitStatus, PRStatus renamed to CommitFlag, PRFlag lbarcziova/ogr
2 participants
@jpopelka @lachmanfrantisek