Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Forgejo comments and reactions on it #883

Open
2 tasks
Tracked by #866
lbarcziova opened this issue Dec 17, 2024 · 12 comments
Open
2 tasks
Tracked by #866

Implement support for Forgejo comments and reactions on it #883

lbarcziova opened this issue Dec 17, 2024 · 12 comments
Assignees
Labels
area/forgejo complexity/single-task Regular task, should be done within days. good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement.

Comments

@lbarcziova
Copy link
Member

lbarcziova commented Dec 17, 2024

Client usage docs: https://codeberg.org/harabat/pyforgejo#usage


Part of #866

@lbarcziova lbarcziova mentioned this issue Dec 17, 2024
10 tasks
@lbarcziova lbarcziova added area/forgejo kind/feature New feature or a request for enhancement. complexity/single-task Regular task, should be done within days. labels Dec 17, 2024
@lbarcziova lbarcziova moved this from new to backlog in Packit Kanban Board Dec 23, 2024
@lbarcziova lbarcziova added the good-first-issue Good for newcomers. label Mar 18, 2025
@julietowah
Copy link

Hello, @lbarcziova
I would love to work on this issue

@lbarcziova
Copy link
Member Author

hi @julietowah , I have assigned you, feel free to ask if anything is unclear :)

@julietowah
Copy link

Ok thank you Am on it

@julietowah
Copy link

julietowah commented Mar 20, 2025

Hello, @lbarcziova i am done with implementing the methods for this issue but the building of the test image following the documentation is where i gut stuck.

i installed the ansible-bender but when i run make build-test-image am getting this error

ansible-bender build --build-volumes /home/juliet/ogr:/src:Z -- ./recipe.yaml fedora:latest ogr
16:32:50.660 utils.py          ERROR  Resolved "fedora" as an alias (/etc/containers/registries.conf.d/shortnames.conf)
16:32:50.661 utils.py          ERROR  Trying to pull registry.fedoraproject.org/fedora:latest...
16:33:04.344 utils.py          ERROR  Getting image source signatures
16:33:04.348 utils.py          ERROR  Copying blob sha256:bfa20db43df552b1a9d230d4c98ed9c96893c8334b7af253dbcae4174b16718a
16:33:12.850 utils.py          ERROR  Copying blob sha256:bfa20db43df552b1a9d230d4c98ed9c96893c8334b7af253dbcae4174b16718a
16:33:40.052 utils.py          ERROR  Copying config sha256:3acda6fe1bd0793ef63e491cefc392410d34d76f91018b741b2d35415d98514e
16:33:40.057 utils.py          ERROR  Writing manifest to image destination
16:33:40.057 utils.py          ERROR  Storing signatures
16:33:44.260 buildah_builder.py ERROR  couldn't locate python interpreter, tried these paths: ('/usr/bin/python3', '/usr/local/bin/python3', '/usr/bin/python3.7', '/usr/bin/python37', '/usr/bin/python3.6', '/usr/bin/python36', '/usr/bin/python2', '/usr/local/bin/python2', '/usr/bin/python', '/usr/local/bin/python', '/usr/libexec/platform-python')
There was an error during execution: no python interpreter was found in the base image "fedora:latest", you can specify the path via CLI option --python-interpreter
make: *** [Makefile:9: build-test-image] Error 2 ```



please can you help me to setup the test image file

@LecrisUT
Copy link

ERROR in this case I believe reffers to srderr output screen which does not necessarily mean error. The last part describes your error, it couldn't find your system python. If you have a python venv setup make sure you activate it before running the make commands, otherwise can you check where your python interpreter is with

$ which python3

PS: please format code blocks like

```
Long list of code
With multiple lines
```

@LecrisUT
Copy link

Ok with the formatted text it's a bit clearer, the missing python interpreter is in the fedora:latest image. Fedora used to have python installed by default due to dnf4, but since dnf5 that's not the case. One quick fix you could do is to find a fedora image that has it maybe

$ make BASE_IMAGE=fedora:40 build-test-image

If others are able to run it normally though there is an error somewhere before that in ansible-blender

@nforro
Copy link
Member

nforro commented Mar 21, 2025

If others are able to run it normally though there is an error somewhere before that in ansible-blender

No, it looks like starting with Fedora 41 the container images don't have /usr/bin/python3 by default.

@nforro
Copy link
Member

nforro commented Mar 21, 2025

There is a long open upstream issue about that: ansible-community/ansible-bender#49
For now I would stick with the recommendation from @LecrisUT:

$ make BASE_IMAGE=fedora:40 build-test-image

@julietowah
Copy link

@LecrisUT and @nforro thank you so much let me do that

@julietowah
Copy link

please @LecrisUT can you make out time to look at my codebase i cant get the test right i think my setup is messed up

following the documentation in https://github.com/packit/contributing i installed the dependencies maybe i missed a step because i encountered this

 ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --cov=ogr --cov-report=term-missing
  inifile: None
  rootdir: /src

when i run: make check-in-container

@LecrisUT
Copy link

It seems the image is missing pytest-cov. Can you add it here and re-run build-test-image

@julietowah
Copy link

Yes i thought as much
thank you so much
it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/forgejo complexity/single-task Regular task, should be done within days. good-first-issue Good for newcomers. kind/feature New feature or a request for enhancement.
Projects
Status: backlog
Development

No branches or pull requests

4 participants