Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store number of found defects for OSH scans #2641

Merged

Conversation

lbarcziova
Copy link
Member

Fixes #2625

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

@lbarcziova lbarcziova requested a review from a team as a code owner November 14, 2024 14:05
Copy link
Contributor

Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to expose it in the API in a follow-up? Or it's just for stats? 👀

@lbarcziova
Copy link
Member Author

Want to expose it in the API in a follow-up? Or it's just for stats?

good point! It is mostly for stats, but having it in the API (and displaying) may be beneficial as well, will add it here

Copy link
Contributor

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Nov 15, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1b2fe4dcd1b84facbea4551aa0818d4b

✔️ pre-commit SUCCESS in 2m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0b100f3 into packit:main Nov 15, 2024
4 checks passed
@siteshwar
Copy link
Contributor

Please do not use the word "defect" to refer "findings". I understand that word is used too many times in the OSH code, but please do not refer to it in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track number of detected OpenScanHub findings
3 participants