Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #10

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 20, 2024

pre-commit-ci bot and others added 4 commits February 29, 2024 15:44
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.2.1 → v0.2.2](astral-sh/ruff-pre-commit@v0.2.1...v0.2.2)
Enable the linting of ‹async› code, since we now have some ‹async› in
here.

Signed-off-by: Matej Focko <[email protected]>
Previous structure of the config has been deprecated, therefore update
to the new one.

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'allowed-confusables' -> 'lint.allowed-confusables'
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'unfixable' -> 'lint.unfixable'
  - 'flake8-tidy-imports' -> 'lint.flake8-tidy-imports'
  - 'isort' -> 'lint.isort'
  - 'pydocstyle' -> 'lint.pydocstyle'
  - 'per-file-ignores' -> 'lint.per-file-ignores'

Signed-off-by: Matej Focko <[email protected]>
This issue was raised by the pre-commit update of the ruff, which
uncovered that it is possible to have the dangling (unsaved) tasks
garbage-collected before they run/finish. Fix this issue by keeping the
tasks in ‹set›.

Reference: https://docs.astral.sh/ruff/rules/asyncio-dangling-task/

Signed-off-by: Matej Focko <[email protected]>
@mfocko mfocko force-pushed the pre-commit-ci-update-config branch from 4e30c14 to 95b467a Compare February 29, 2024 14:44
@mfocko mfocko requested a review from majamassarini February 29, 2024 14:45
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't know about the dangling tasks, good to know :) 🙏🏻

@mfocko mfocko self-assigned this Mar 1, 2024
@mfocko mfocko added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 5f0e20e Mar 1, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the pre-commit-ci-update-config branch March 1, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants