Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set ingress path other than / #70

Open
manali14 opened this issue Oct 31, 2023 · 3 comments
Open

Unable to set ingress path other than / #70

manali14 opened this issue Oct 31, 2023 · 3 comments

Comments

@manali14
Copy link

In ingress there is no way to set any other Prefix other than /, so its difficult to configure pact to a custom path.

Details here: https://github.com/pact-foundation/pact-broker-chart/blob/master/charts/pact-broker/templates/ingress.yaml#L33

In order to get it working, I have to disable ingress from helm chart and create it separately because my pact server is running on a custom path i.e, /pact

@ChrisJBurns
Copy link
Contributor

ChrisJBurns commented Nov 1, 2023

Hi @manali14

Just looking at this now, would the addition of a pathPrefix value be suffice? An example:

       paths:
          - path: {{ Values.ingress.path }}
            pathType: Prefix

Where ingress.path is defaulted to / for backwards compatibility. You should then be able to use it by passing in ingress.path: "/pact"

@tw-kushalbajaj
Copy link

Hi @ChrisJBurns
Did we find a way to achieve this without having to add a copy of repo locally ?

@ChrisJBurns
Copy link
Contributor

Hi, I'm awaiting @manali14 response on this one, but in order to get this in, we might have to put a basic working version of an ingress resource in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants