Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early in clean.sh #139

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fail early in clean.sh #139

merged 1 commit into from
Sep 11, 2023

Conversation

id-ilych
Copy link
Contributor

Update clean shell script to fail if any of the commands fail

@id-ilych
Update clean.sh
1204657 
Update clean shell script to fail if any of the commands fail
@mefellows mefellows added the smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear label Jul 31, 2023
@YOU54F YOU54F requested review from bethesque and YOU54F September 11, 2023 15:57
@YOU54F
Copy link
Member

YOU54F commented Sep 11, 2023 •
edited
Loading

makes sense to me, thank you!

@bethesque bethesque merged commit adbf9af into pact-foundation:master Sep 11, 2023
@id-ilych id-ilych deleted the patch-1 branch September 12, 2023 10:16
@id-ilych
Copy link
Contributor Author

Hey @YOU54F and @bethesque 👋

Thank you for taking care of this PR 🙇
Could you also take a look at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

@bethesque bethesque Awaiting requested review from bethesque

Assignees
No one assigned
Labels
smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@id-ilych @YOU54F @mefellows @bethesque