Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Fix method return type hint #697

Merged
merged 1 commit into from
Dec 2, 2024
Merged

style: Fix method return type hint #697

merged 1 commit into from
Dec 2, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 2, 2024

Fix this error:

Method PhpPactTest\Consumer\MessageBuilderTest::getCallbacks() should return array<int|string, callable():  
         mixed> but returns array.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12125080350

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.3%
Totals Coverage Status
Change from base Build 12103028376: 0.0%
Covered Lines: 2577
Relevant Lines: 2676
💛 - Coveralls

@tienvx tienvx merged commit 03504fb into pact-foundation:master Dec 2, 2024
20 checks passed
@tienvx tienvx deleted the fix-method-return-type-hint branch December 2, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis