-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release node base image in new Github Actions release workflow #28
Comments
I'm a bit confused by the state of play here There are three Do we just need to release 3? I fixed the build pipeline, for 1, so it is publishing again
|
We used to have an automatic build in Dockerhub. Since we lost the free builds there due to Dockerhub's change in policy, I moved the builds to Github Actions. I migrated the default dockerfile, but never got around to migrating the Dockerfile-node-14 one. The tags are the same with Dockerfile-bundle-base is only used in the update process. It is not published anywhere. |
I did the work on the image to update it, but I'm not sure how much use it is going to be to pact-js (node users) current guidance is don't use alpine https://docs.pact.io/docker#alpine-linux We release a musl artefact for the pact ffi, its a static lib https://github.com/pact-foundation/pact-reference/releases/tag/libpact_ffi-v0.4.4 I've unofficially been building additional pact ffi targets https://github.com/YOU54F/pact-reference/blob/multi_arch/COMPATIBILITY.md and got Would need client libs that use the pact_ffi to detect the user is on linux, but also a musl(er) distro. I think ruby has detection for that, as it supports musl platforms |
pact-js does now support alpine pact-foundation/pact-js-core#507 and docker guidance for alpine being updated here pact-foundation/docs.pact.io#345 existing images. https://hub.docker.com/r/pactfoundation/pact-cli/tags?page_size=&ordering=&name=node we will also want to publish to ghcr. good first issue for someone, although it would be good to see download stats for the node images, to see if anyone has used them (we haven't had any requests to publish new versions of the node tagged images) |
No description provided.
The text was updated successfully, but these errors were encountered: