Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add more documentation to the example ruby rakefile? #101

Open
bewatts opened this issue Dec 2, 2021 · 3 comments
Open

Can we add more documentation to the example ruby rakefile? #101

bewatts opened this issue Dec 2, 2021 · 3 comments

Comments

@bewatts
Copy link

bewatts commented Dec 2, 2021

I'm trying out Pact, and having a hard time going from the naive examples to a semi-real system with pacts shared across services using a local pact broker.

In both this repo, and in the "Publishing Pacts" doc, there's not really any explanation for what some of the configurations are. I'm particularly confused by the require 'my_consumer/version'' line. Connecting that to one of the many concrete examples would help, as would explaining why each line is required, and what purposes it serves.

@bethesque
Copy link
Member

Good suggestions Ben. It needs an update.

Just quickly:

require 'my_consumer/version'

Was left over from when we suggested people publish pacts with the version number of the gem. Now we recommend using the git sha. That line needs to be removed.

You'll get better docs for each field if you run bundle exec pact-broker help publish. It should be clear which CLI field maps to the Ruby field, but let me know if you can't work it out.

@bethesque
Copy link
Member

Here's a real world example, but it's a very complicated one, because I'm doing some fancy stuff with feature branches, so it may not actually be very helpful. https://github.com/pact-foundation/pact_broker-client/blob/master/tasks/pact.rake

@bewatts
Copy link
Author

bewatts commented Dec 9, 2021

Awesome, thanks @bethesque!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants