-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ostruct will be dropped from stdlib in Ruby 3.5.0 #173
Comments
For a bit of history We are using json 2.7.1 (it is part of the standard lib for ruby 3.3.5 which we are using in traveling ruby) When we move to ruby 3.4.x on release, we can bump the json gem in traveling ruby to 2.7.2 (currently locked in the pact-ruby-standalone repo, so we use std gems, and can build windows packages, as traveling ruby doesn't support building native extensions for windows) json 2.7.2 makes the requirement on ostruct optional, but ostruct itself is required in a few of our projects explicitly so makes sense to add it. |
Added the same for other usages of ostruct, adding a dev dep, where it is only used in specs |
New versions of pact-ruby-standalone / pact-ruby-cli / pact-js-cli now going out |
we've got one more on windows, this time for fiddle. I've formatted for readability
Looks to be related to ruby/fiddle#145 replicated in windows builds
|
In the latest version of the CLI, the following warning is presented:
In general, fixing this should be a matter of making it an explicit dependency, albeit this might just be a matter of updating downstream dependencies.
Example PRs for other projects:
The text was updated successfully, but these errors were encountered: