fix: ensure database and basic auth credentials are not coerced to ar…

…rays if they contain commas
pact-foundation · Mar 21, 2022 · 5bce7ce · 5bce7ce
1 parent aebb6bd
commit 5bce7ce
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/pact_broker/config/basic_auth_configuration.rb b/lib/pact_broker/config/basic_auth_configuration.rb
@@ -20,6 +20,13 @@ def self.included(anyway_config)
 
           sensitive_values(:basic_auth_password, :basic_auth_read_only_password)
 
+          coerce_types(
+            basic_auth_username: :string,
+            basic_auth_password: :string,
+            basic_auth_read_only_username: :string,
+            basic_auth_read_only_password: :string
+          )
+
           def basic_auth_credentials_provided?
             basic_auth_username&.not_blank? && basic_auth_password&.not_blank?
           end

diff --git a/lib/pact_broker/config/runtime_configuration_database_methods.rb b/lib/pact_broker/config/runtime_configuration_database_methods.rb
@@ -31,6 +31,11 @@ def self.included(anyway_config)
             database_connection_validation_timeout: nil
           )
 
+          coerce_types(
+            database_username: :string,
+            database_password: :string
+          )
+
           def database_configuration
             database_credentials
               .merge(