Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pacts by branch is not deleting the pacts #628

Open
bethesque opened this issue Aug 7, 2023 · 4 comments
Open

Delete pacts by branch is not deleting the pacts #628

bethesque opened this issue Aug 7, 2023 · 4 comments

Comments

@bethesque
Copy link
Member

Pre issue-raising checklist

Software versions

Expected behaviour

Pacts are deleted

Actual behaviour

Pacts are not deleted

Steps to reproduce

DELETE https://broker/pacts/provider/my_provider/consumer/my_consumer/branch/chore%2Fupdate-dependencies

Relevant log files

@mefellows
Copy link
Member

Following up on this, it seems to always return a 200 so long as the consumer/provider pair exists, no matter what branch you give it. In fact, as long as both pacticipants exist (even if no integration exists) it still returns a 200. You can even pass in the same pacticipant for both the provider and consumer.

@mefellows mefellows added the smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear label Jul 23, 2024
Copy link

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-2239). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

@bethesque
Copy link
Member Author

bethesque commented Aug 20, 2024

Low priority.

This is not a very useful endpoint anyway. If you want to clean up branch related data for a pacticipant, you want to delete the pacts for all consumers for that branch, not just for a specific consumer. I think I just wrote this endpoint because I was trying to match all the previous endpoints that had tags in them. I don't know if anyone has ever used it except for me. You could try checking the pactflow logs to see if it's ever been used.

@mefellows mefellows removed the smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear label Aug 29, 2024
@mefellows
Copy link
Member

Thanks Beth, removing smartbear supported label given low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New Issue
Development

No branches or pull requests

2 participants