Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended vs default selectors #705

Open
mefellows opened this issue Jul 22, 2024 · 2 comments
Open

Recommended vs default selectors #705

mefellows opened this issue Jul 22, 2024 · 2 comments
Labels
enhancement Indicates new feature requests question Indicates that an issue, pull request, or discussion needs more information smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear

Comments

@mefellows
Copy link
Member

The current default selectors of the broker seem to be:

  1. latest version on the main branch
  2. all versions that have been deployed
  3. all versions that are currently marked as released.

However, the current recommended selectors are

These are the recommended selectors that will cover the majority of workflows.

- `{ "mainBranch": true }` - the latest version from the main branch of each consumer, as specified by the consumer's `mainBranch` property.
- `{ "branch": "<branch>" }` - the latest version from a particular branch of each consumer.
- `{ "deployedOrReleased": true }` - all the currently deployed and currently released and supported versions of each consumer.
- `{ "matchingBranch": true }` - the latest version from any branch of the consumer that has the same name as the current branch of the provider. Used for coordinated development between consumer and provider teams using matching feature branch names.

The lack of branch in the default makes sense (needs the branch to be supplied) but matchingBranch seems like it could be inferred if the provider specifies it.

It would make sense for the recommended selectors to be the default, so most users can point at the broker and have a functional workflow without additional work. This would also simplify the docs.

@mefellows mefellows added enhancement Indicates new feature requests question Indicates that an issue, pull request, or discussion needs more information smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear labels Jul 22, 2024
Copy link

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-2230). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

@YOU54F
Copy link
Member

YOU54F commented Jul 31, 2024

Some thoughts around this were penned by Beth in this discussion

#391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests question Indicates that an issue, pull request, or discussion needs more information smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Development

No branches or pull requests

2 participants