Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Partial / Unimplemented Moves and Abilities #3503

Open
58 tasks
frutescens opened this issue Aug 12, 2024 · 28 comments
Open
58 tasks

List of Partial / Unimplemented Moves and Abilities #3503

frutescens opened this issue Aug 12, 2024 · 28 comments
Assignees
Labels
Ability Affects an ability Move Affects a move

Comments

@frutescens
Copy link
Contributor

frutescens commented Aug 12, 2024

Last Updated: 2024-12-03

Edge Cases

  • Commander (A)
  • Gulp Missile

Partial Moves

Unimplemented Moves

Partial Abilities

  • Infilitrator [Ability] Partially Implement Infiltrator #4636
  • Sheer Force
  • Harvest
  • Victory Star
  • Cheek Pouch
  • Flower Gift
  • Sweet Veil
  • Shields Down
  • Corrosion
  • Wandering Spirit
  • Neutralizing Gas
  • Protosynthesis
  • Good as Gold
  • Quark Drive
  • Supreme Overlord
  • Embody Aspect abilities

Unimplemented Abilities

@Tempo-anon
Copy link
Collaborator

All the healing abilities should not be marked as (P) because of heal blocking. They are complete and it should be up to the heal blocking implementation to properly implement blocking heals of abilities

@frutescens
Copy link
Contributor Author

I believe the decisions around (P) designation was separate from the actual Heal Block PR, which was created to resolve and remove those (P) labels.

@frutescens
Copy link
Contributor Author

Balance Notes for Moves / Abilities

Move - Natural Gift

  • Gens IV-V : BP ranges from 60-80
  • Gen VI : BP ranges from 80-100
  • Type dependent on berry
  • In mainline, BP decisions are based on the Pokemon typically having access to only one berry per battle + a wider selection of berries = can represent the full range of types
  • In Pokerogue, Pokemon can stack multiple stacks of berries + can "spam" this move

Move - Fling

  • Similar concerns to Natural Gift

Ability - Cud Chew

  • In mainline, a berry's effect activates again at the end of the turn it was consumed.
  • In Pokerogue, multiple berries can be activated per turn.

Ability - Unburden

  • Mainline: Doubles the Pokemon's speed stat when its held item is used or lost
  • Multiple berries / items can be lost per turn.

@PyGaVS
Copy link
Contributor

PyGaVS commented Aug 12, 2024

Illusion ability pr here : #3273

@DayKev
Copy link
Collaborator

DayKev commented Aug 12, 2024

Btw the [ ] won't turn into checkboxes unless they're on their own line (and as part of a "list" aka you need * at the start of each line).
Ex:

  • a
  • b
  • ...

Which is:

* [x] a
* [ ] b
* ...

@torranx
Copy link
Contributor

torranx commented Aug 13, 2024

Gulp Missile and Flame Burst are already finished
Forecast in progress (tho no PR)

@Snailman11
Copy link
Collaborator

Snailman11 commented Aug 13, 2024

Rollout and Future Sight should be marked P as Rollout does not currently lock the user into the move, and Future Sight's #1568. The latter also currently has a problem where it doesn't fail if used when the move is loaded, and an incorrect interaction with calling moves.

Edit: Ice Ball and Doom Desire share attributes and incompleteness with those moves, if they should be marked P as well.

@DayKev
Copy link
Collaborator

DayKev commented Aug 13, 2024

Heatproof should be added as (P) until #3524 is merged.

@torranx
Copy link
Contributor

torranx commented Aug 13, 2024

Forecast draft PR #3534

@Snailman11
Copy link
Collaborator

#3006
Ability immunity popups aren't showing, not sure if that's why sweet veil is P

@Snailman11
Copy link
Collaborator

Snailman11 commented Aug 27, 2024

#3856
Tera Shell (in review)

@ysh4296
Copy link
Contributor

ysh4296 commented Aug 28, 2024

Power Trick Draft PR #2658

waiting for related task(#2699) done

@Snailman11
Copy link
Collaborator

Snailman11 commented Sep 5, 2024

Please mark Compound eyes (P) to be in
line with Superluck. Both are missing their out-of-combat ability. https://discord.com/channels/1125469663833370665/1176874654015684739/1280967841763430543

@DayKev
Copy link
Collaborator

DayKev commented Sep 8, 2024

Linked the Gorilla Tactics PR to the item in the list.

@DayKev DayKev pinned this issue Sep 8, 2024
@Snailman11
Copy link
Collaborator

Snailman11 commented Sep 13, 2024

Make Sky Drop (P) or (N) because it's currently a worse Fly clone
https://discord.com/channels/1125469663833370665/1282035866226790473

  new AttackMove(Moves.SKY_DROP, Type.FLYING, MoveCategory.PHYSICAL, 60, 100, 10, -1, 0, 5)
      .attr(ChargeAttr, ChargeAnim.SKY_DROP_CHARGING, i18next.t("moveTriggers:tookTargetIntoSky", {pokemonName: "{USER}", targetName: "{TARGET}"}), BattlerTagType.FLYING) // TODO: Add 2nd turn message
      .condition(failOnGravityCondition)
      .ignoresVirtual(),

@Snailman11
Copy link
Collaborator

Snailman11 commented Sep 15, 2024

Freeze dry seems to be missing from the partial moves list
Screenshot_20240914-173612

@qorenta
Copy link

qorenta commented Oct 21, 2024

Pollen Puff should be (P) or (N). If I use it on my 2nd Pokemon in a double battle, it deals damage instead of healing as it should,

@DayKev
Copy link
Collaborator

DayKev commented Oct 21, 2024

Pollen Puff should be (P) or (N). If I use it on my 2nd Pokemon in a double battle, it deals damage instead of healing as it should,

Pollen Puff has been fixed in #4615 which will be in the next update.

@Snailman11
Copy link
Collaborator

Snailman11 commented Oct 28, 2024

Add P to Last Respects as It currently resets every wave

also need to specify in code
-Something like Supreme Overlord's
// Counter resets every wave

https://discord.com/channels/1125469663833370665/1296494418173493338

@geeilhan
Copy link
Contributor

geeilhan commented Nov 15, 2024

I have tested

new AttackMove(Moves.SUNSTEEL_STRIKE, Type.STEEL, MoveCategory.PHYSICAL, 100, 100, 5, -1, 0, 7)
      .ignoresAbilities()
      .edgeCase(), // Should not ignore abilities when called virtually (metronome)

as well as Moongeist Beam and Photon Geysers edge case with Metronome, Copycat and Sleep talk and it correctly ignores the MoveFlags.IGNORE_ABILITIES flag.
That is because checkFlag(MoveFlags.IGNORE_ABILITIES, this.pokemon, null) is only called if the move is not a follow-up move. The moves copied and used by Metronome, Copycat and Sleep talk are follow up moves and therefore no checkFlag(MoveFlags.IGNORE_ABILITIES, this.pokemon, null) is called.

// Reset hit-related turn data when starting follow-up moves (e.g. Metronomed moves, Dancer repeats)
    if (this.followUp) {
      //console.log("This is a follow up move");
      this.pokemon.turnData.hitsLeft = -1;
      this.pokemon.turnData.hitCount = 0;
    }

    // Check move to see if arena.ignoreAbilities should be true.
    if (!this.followUp) {
      //console.log("This is not a follow up move");
      if (this.move.getMove().checkFlag(MoveFlags.IGNORE_ABILITIES, this.pokemon, null)) {
        this.scene.arena.setIgnoreAbilities(true, this.pokemon.getBattlerIndex());
      }
    }

(Source: src/phases/move-phase.ts)

Does this count as Moongeist Beam, Photon Geyser and Sunsteel Strike being fully implemented?

@DayKev
Copy link
Collaborator

DayKev commented Nov 16, 2024

Added Roar/etc to the list of Partial Moves.

@Snailman11
Copy link
Collaborator

Rage Fist should be marked P in accordance with Balance's Decision on Last Respects, Supreme Overlord, that it should not be resetting per wave as it does currently

https://discord.com/channels/1125469663833370665/1231959360188452954

@DayKev
Copy link
Collaborator

DayKev commented Nov 17, 2024

Rage Fist should be marked P in accordance with Balance's Decision on Last Respects, Supreme Overlord, that it should not be resetting per wave as it does currently

https://discord.com/channels/1125469663833370665/1231959360188452954

👍 #4894

@Snailman11
Copy link
Collaborator

Snailman11 commented Nov 19, 2024

Mark Analytic P due to it not working correctly in double battles
#298

If a Pokémon with Analytic executes its move after all other Pokémon have made their move, the power of its move is increased by 30% (approximated as a factor of 5325/4096).

PokeRogue.and.6.more.pages.-.Personal.-.Microsoft.Edge.2024-11-18.21-12-18.mp4

@Snailman11
Copy link
Collaborator

Snailman11 commented Nov 19, 2024

Also Stakeout against Switch Moves

Stakeout.P.1.mp4

#298

@Bertie690
Copy link
Contributor

Bertie690 commented Dec 2, 2024

Instruct should be marked as P now with the new instruct PR being merged earlier.

@DayKev DayKev moved this from Done to In Progress in Partial/Unimplemented Moves and Abilities Dec 2, 2024
@DayKev
Copy link
Collaborator

DayKev commented Dec 4, 2024

If enemy uses Knock-off no item gets knocked off

Screencast.from.2024-12-04.19-52-55.webm

That's intended.

Wild Pokémon cannot remove held items of the player's Pokémon.

@geeilhan
Copy link
Contributor

geeilhan commented Dec 5, 2024

If enemy uses Knock-off no item gets knocked off
Screencast.from.2024-12-04.19-52-55.webm

That's intended.

Wild Pokémon cannot remove held items of the player's Pokémon.

I see thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability Move Affects a move
Projects
Development

No branches or pull requests

10 participants