[Hotfix] Prevent crash if enemy Future Sight user is caught #4905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
The game will no longer crash if a Pokémon that used Future Sight is caught.
Why am I making these changes?
Bug report: https://discord.com/channels/1125469663833370665/1307871092261523567
What are the changes from a developer perspective?
If the user of the move in
MoveEffectPhase
has no turn data and it's a delayed attack (ie: Future Sight), initialize it.Pokemon.pushMoveHistory()
checks if the Pokémon is on the field and returns early if it isn't.Screenshots/Videos
future.sight.crash.fix.mp4
How to test the changes?
Use these overrides and start a new run. Stall the first turn so the enemy Pokémon uses Future Sight, then catch it the next turn. In the following turn, do whatever, and get hit by the Future Sight attack. At this point the game should continue on as normal instead of crashing.
Checklist
[ ] I'm usingbeta
as my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)[ ] Are the changes visual?