Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "kite offline" iframe content URL configurable #46

Open
BjarniRunar opened this issue Nov 2, 2017 · 2 comments
Open

Make the "kite offline" iframe content URL configurable #46

BjarniRunar opened this issue Nov 2, 2017 · 2 comments

Comments

@BjarniRunar
Copy link
Collaborator

Currently the URL for the "fancy" version of the "kite offline" error page is hard coded. It should be configurable at runtime.

@guillerodriguez
Copy link
Contributor

There is now an option to make the "offline" url configurable. However even if this is used, there are still mentions of pagekite in the HTML boilerplate. You may consider to change this for consistency with the way it is currently done in PyPagekite:

# Do we have a more specific error URL for this domain? This is a
# white-label feature, for folks not wanting to hit the PageKite.net
# servers at all. In case of a match, we also disable mention of
# PageKite itself in the HTML boilerplate.

https://github.com/pagekite/PyPagekite/blob/602dc67d5626ef38d4013ece52bcf54eb8522f9e/pagekite/proto/selectables.py#L601

@BjarniRunar
Copy link
Collaborator Author

Agreed, leaving this open until that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants