Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Static Analysis worksflow] Retrieve pre-commit version from .pre-commit-config.yaml #256

Open
rodoviti opened this issue Jan 31, 2025 · 2 comments · May be fixed by #260
Open

[Static Analysis worksflow] Retrieve pre-commit version from .pre-commit-config.yaml #256

rodoviti opened this issue Jan 31, 2025 · 2 comments · May be fixed by #260
Labels
question Further information is requested

Comments

@rodoviti
Copy link

Can you make pre_commit_tf_tag input optional and then add the "same" logic as you did with terraform_version input?

What i mean is to add a new action, such as get-terraform-version, to retrieve the pre-commit version from .pre-commit-config.yaml file and use it inside static_analysis.yaml workflow if pre_commit_tf_tag input is missing.

What do you think about that?

@rodoviti rodoviti added the question Further information is requested label Jan 31, 2025
@gunzip
Copy link
Contributor

gunzip commented Jan 31, 2025

It looks like it has a default, so it's already optional. Do you mean that the default value may be misaligned from the pre-commit configuration?

@gunzip
Copy link
Contributor

gunzip commented Jan 31, 2025

cc @christian-calabrese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants