Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nginx build order after re-architecture #129

Open
Tracked by #128
ForestEckhardt opened this issue Sep 26, 2022 · 0 comments
Open
Tracked by #128

Replace nginx build order after re-architecture #129

ForestEckhardt opened this issue Sep 26, 2022 · 0 comments

Comments

@ForestEckhardt
Copy link
Contributor

Describe the Enhancement

RFC 0007 has been approved and merged.

Possible Solution

The currently existing nginx build orders need to be replaced with the following.

NPM Frontend

[[order]]

  [[order.group]]
    id = "paketo-buildpacks/ca-certificates"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/watchexec"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/node-engine"

  [[order.group]]
    id = "paketo-buildpacks/npm-install"

  [[order.group]]
    id = "paketo-buildpacks/node-run-script"

  [[order.group]]
    id = "paketo-buildpacks/nginx"

  [[order.group]]
    id = "paketo-buildpacks/nginx-zero-configuration"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/nginx-start"

  [[order.group]]
    id = "paketo-buildpacks/environment-variables"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/image-labels"
    optional = true

Yarn Frontend

[[order]]

  [[order.group]]
    id = "paketo-buildpacks/ca-certificates"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/watchexec"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/node-engine"

  [[order.group]]
    id = "paketo-buildpacks/yarn"

  [[order.group]]
    id = "paketo-buildpacks/yarn-install"

  [[order.group]]
    id = "paketo-buildpacks/node-run-script"

  [[order.group]]
    id = "paketo-buildpacks/nginx"

  [[order.group]]
    id = "paketo-buildpacks/nginx-zero-configuration"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/nginx-start"

  [[order.group]]
    id = "paketo-buildpacks/environment-variables"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/image-labels"
    optional = true

Standard

[[order]]

  [[order.group]]
    id = "paketo-buildpacks/ca-certificates"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/watchexec"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/nginx-dist"

  [[order.group]]
    id = "paketo-buildpacks/nginx-zero-configuration"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/nginx-start"

  [[order.group]]
    id = "paketo-buildpacks/procfile"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/environment-variables"
    optional = true

  [[order.group]]
    id = "paketo-buildpacks/image-labels"
    optional = true

Motivation

This is part of #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Not scoped
Development

No branches or pull requests

1 participant