Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are SafeIllegalArgumentExceptions 400s? #1311

Open
TheBeruriahIncident opened this issue Nov 4, 2019 · 0 comments
Open

Why are SafeIllegalArgumentExceptions 400s? #1311

TheBeruriahIncident opened this issue Nov 4, 2019 · 0 comments

Comments

@TheBeruriahIncident
Copy link
Contributor

Now that we push for using the logsage preconditions everywhere, this means that random bugs deep in the code will effectively cause 400s. The philosophy elsewhere on our api seems to be intentionality and being very careful about what we expose, etc

Additionally, it's kind of subtle and confusing that checkState is a 500 and checkArgument is a 400, even when they have nothing to do with a direct client input.

What happened?

checkArgument causes 400s even when having nothing to do with client issues

What did you want to happen?

Only getting 400s from client issues. Presumably we should have to be explicit about what's a 400 (this is currently true in most other cases).

Essentially, I propose that there's not an exception mapper for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant