remove comment

palantir · Feb 2, 2023 · 9751939 · 9751939
1 parent ff296a9
commit 9751939
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/conjure-java-core/src/test/java/com/palantir/conjure/java/types/SafetyEvaluatorTest.java b/conjure-java-core/src/test/java/com/palantir/conjure/java/types/SafetyEvaluatorTest.java
@@ -137,13 +137,12 @@ void testMapSafeKey() {
                 .types(object)
                 .types(SAFE_ALIAS)
                 .build();
-        // there's an ABI break between 4.28.0 -> 4.36.0
         ConjureDefinitionValidator.validateAll(conjureDef, SafetyDeclarationRequirements.ALLOWED);
         SafetyEvaluator evaluator = new SafetyEvaluator(conjureDef);
         assertThat(evaluator.evaluate(object)).isEmpty();
     }
 
-    private static Stream<Arguments> providesExternalRefTypes_ImportTime() {
+    private static Stream<Arguments> providesExternalRefTypes_WithSafety() {
         Type external = Type.external(ExternalReference.builder()
                 .externalReference(TypeName.of("Long", "java.lang"))
                 .fallback(Type.primitive(PrimitiveType.STRING))
@@ -153,8 +152,8 @@ private static Stream<Arguments> providesExternalRefTypes_ImportTime() {
     }
 
     @ParameterizedTest
-    @MethodSource("providesExternalRefTypes_ImportTime")
-    void testExternalRefType_AtImportTime(TypeDefinition typeDefinition, ConjureDefinition conjureDef) {
+    @MethodSource("providesExternalRefTypes_WithSafety")
+    void testExternalRefType_WithSafety(TypeDefinition typeDefinition, ConjureDefinition conjureDef) {
         ConjureDefinitionValidator.validateAll(conjureDef, SafetyDeclarationRequirements.ALLOWED);
         SafetyEvaluator evaluator = new SafetyEvaluator(conjureDef);
         assertThat(evaluator.evaluate(typeDefinition)).hasValue(LogSafety.DO_NOT_LOG);