Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: palantir/gradle-baseline
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.48.0
Choose a base ref
...
head repository: palantir/gradle-baseline
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref

Commits on Nov 4, 2020

  1. Allow ErrorProne to qualify JavaTimeSystemDefaultTimeZone fix types (#…

    …1533)
    
    Allow ErrorProne to qualify JavaTimeSystemDefaultTimeZone fix types
    carterkozak authored Nov 4, 2020
    Copy the full SHA
    a4473c5 View commit details

Commits on Nov 10, 2020

  1. Update maven-dependency-analyzer (#1537)

    Update maven-dependency-analyzer
    fawind authored Nov 10, 2020
    Copy the full SHA
    0e768c4 View commit details
  2. Excavator: Upgrades gradle wrapper to the latest version (#1538)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 10, 2020
    Copy the full SHA
    a095ffc View commit details

Commits on Nov 11, 2020

  1. Excavator: Render CircleCI file using template specified in .circleci…

    …/template.sh (#1539)
    
    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 11, 2020
    Copy the full SHA
    dc094f2 View commit details
  2. Update spotless to 5.7.0 (#1534)

    Update spotless to 5.7.0
    fawind authored Nov 11, 2020
    Copy the full SHA
    958e339 View commit details
  3. Autorelease 3.49.0

    svc-autorelease committed Nov 11, 2020
    Copy the full SHA
    29bfa00 View commit details
  4. Excavator: Upgrades Baseline to the latest version (#1515)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 11, 2020
    Copy the full SHA
    d72a60a View commit details
  5. Excavator: Upgrade dependencies (#1536)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 11, 2020
    Copy the full SHA
    2e86c84 View commit details

Commits on Nov 12, 2020

  1. Excavator: Upgrade dependencies (#1540)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 12, 2020
    Copy the full SHA
    4e9f5c7 View commit details
  2. Excavator: Upgrade dependencies (#1541)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 12, 2020
    Copy the full SHA
    f4c1fea View commit details
  3. Disable --release flag when --add-exports is used (#1542)

    Disable --release flag when --add-exports is used
    fawind authored Nov 12, 2020
    Copy the full SHA
    06f16e6 View commit details
  4. Autorelease 3.50.0

    svc-autorelease committed Nov 12, 2020
    Copy the full SHA
    fb6ed0f View commit details
  5. Excavator: Upgrades Baseline to the latest version (#1543)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 12, 2020
    Copy the full SHA
    1e0cb58 View commit details

Commits on Nov 13, 2020

  1. Excavator: Upgrade dependencies (#1544)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 13, 2020
    Copy the full SHA
    d88af5f View commit details

Commits on Nov 14, 2020

  1. Excavator: Format Java files (#1545)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 14, 2020
    Copy the full SHA
    86c8657 View commit details

Commits on Nov 16, 2020

  1. Excavator: Upgrade dependencies (#1547)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 16, 2020
    Copy the full SHA
    9323ddf View commit details
  2. Excavator: Upgrades gradle wrapper to the latest version (#1548)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 16, 2020
    Copy the full SHA
    f93de36 View commit details

Commits on Nov 17, 2020

  1. checkstyle 8.36 -> 8.37 (and keep it up to date using excavator) (#1546)

    checkstyle 8.36 -> 8.37, to benefit from some bugfixes to do with new java language features (e.g. records)
    iamdanfox authored Nov 17, 2020
    Copy the full SHA
    bbbaf43 View commit details
  2. Autorelease 3.51.0

    svc-autorelease committed Nov 17, 2020
    Copy the full SHA
    ba96225 View commit details
  3. New plugin: 'com.palantir.baseline-enable-preview-flag' (#1549)

    Add the new line `apply plugin: 'com.palantir.baseline-enable-preview-flag'` to your subprojects block to enable the usage of unreleased java features (e.g. records, switch expressions, var keyword etc).
    
    Note, this plugin is a no-op on any project where you have a low sourceCompatibility.
    iamdanfox authored Nov 17, 2020
    Copy the full SHA
    33f1db9 View commit details
  4. Autorelease 3.52.0

    svc-autorelease committed Nov 17, 2020
    Copy the full SHA
    e7f69c8 View commit details
  5. Fix regression in ./gradlew idea introduced in baseline 3.51.0 (#1551)

    Fix regression in ./gradlew idea introduced in baseline 3.51.0
    iamdanfox authored Nov 17, 2020
    Copy the full SHA
    03ebbce View commit details
  6. Autorelease 3.52.1

    iamdanfox authored and svc-autorelease committed Nov 17, 2020
    Copy the full SHA
    ac49c3d View commit details
  7. Excavator: Upgrades Baseline to the latest version (#1550)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 17, 2020
    Copy the full SHA
    b613a1f View commit details

Commits on Nov 20, 2020

  1. Add PreventUsingIncubatingMethods error-prone check (conjure) (#1554)

    * Add `PreventUsingIncubatingMethods` error-prone check
    
    An explicit check which warns against using incubating APIs; you can
    disable it on a per-project basis, or on a per-usage basis using
    @SuppressWarnings.
    
    * Rename check to 'IncubatingMethod'
    
    To be more in line with other checks.
    
    * Add conjure-lib test dependency, reusable matcher
    
    To ensure we get a compile break if @Incubating ever moves.
    
    * Fix entry in README, add changelog
    
    * Fix version lock & formatting
    Michael "Tres" Brenan authored Nov 20, 2020
    Copy the full SHA
    8ed48f5 View commit details
  2. Autorelease 3.53.0

    svc-autorelease committed Nov 20, 2020
    Copy the full SHA
    fd766af View commit details
  3. Excavator: Upgrades Baseline to the latest version (#1555)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 20, 2020
    Copy the full SHA
    99be1f7 View commit details

Commits on Nov 23, 2020

  1. Improve the DangerousJsonTypeInfoUsage check (#1557)

    Improve the DangerousJsonTypeInfoUsage check
    carterkozak authored Nov 23, 2020
    Copy the full SHA
    db08aec View commit details
  2. Autorelease 3.53.1

    svc-autorelease committed Nov 23, 2020
    Copy the full SHA
    2d9c7b5 View commit details
  3. Excavator: Upgrades Baseline to the latest version (#1558)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 23, 2020
    Copy the full SHA
    27bd5cb View commit details
  4. Apply baseline-class-unqiueness by default (#1553)

    * Apply baseline-class-unqiueness by default
    
    * Add generated changelog entries
    pkoenig10 authored Nov 23, 2020
    Copy the full SHA
    637487d View commit details
  5. Autorelease 3.54.0

    svc-autorelease committed Nov 23, 2020
    Copy the full SHA
    c99c138 View commit details

Commits on Nov 24, 2020

  1. Excavator: Render CircleCI file using template specified in .circleci…

    …/template.sh (#1556)
    
    * Excavator: Render CircleCI file using template specified in .circleci/template.sh
    
    * Use jdk flag and unit-test-15
    
    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    Co-authored-by: fwindheuser <fwindheuser@palantir.com>
    3 people authored Nov 24, 2020
    Copy the full SHA
    02c9f15 View commit details

Commits on Nov 25, 2020

  1. Excavator: Update conjure plugins and dependencies (#1562)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 25, 2020
    Copy the full SHA
    3ef5f32 View commit details
  2. Excavator: Upgrade dependencies (#1563)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 25, 2020
    Copy the full SHA
    ed7f10d View commit details
  3. Excavator: Upgrade dependencies (#1564)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 25, 2020
    Copy the full SHA
    012ed17 View commit details
  4. baseline-format: can format build.gradle files (#1561)

    `com.palantir.baseline-format` now understands how to format build.gradle files. This is opt-in by default, so you need to run `./gradlew format -Pcom.palantir.baseline-format.gradle-files=true` to try it, or add this property to your gradle.properties if you want to lock it in.
    iamdanfox authored Nov 25, 2020
    Copy the full SHA
    8e4eb49 View commit details
  5. Autorelease 3.55.0

    svc-autorelease committed Nov 25, 2020
    Copy the full SHA
    ae8fd16 View commit details
  6. Fix unit tests on java 15 (#1565)

    Fix unit tests on java 15
    fawind authored Nov 25, 2020
    Copy the full SHA
    61d29a5 View commit details
  7. Autorelease 3.56.0

    iamdanfox authored and svc-autorelease committed Nov 25, 2020
    Copy the full SHA
    40551aa View commit details
  8. Add error-prone CompileTimeConstantViolatesLiskovSubstitution check (#…

    …1559)
    
    Add error-prone CompileTimeConstantViolatesLiskovSubstitution check
    carterkozak authored Nov 25, 2020
    Copy the full SHA
    dce9342 View commit details
  9. Autorelease 3.57.0

    svc-autorelease committed Nov 25, 2020
    Copy the full SHA
    7a7ac96 View commit details
  10. Excavator: Update conjure plugins and dependencies (#1566)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 25, 2020
    Copy the full SHA
    6c6692d View commit details

Commits on Nov 26, 2020

  1. Fix path sensitivity of compile tasks (#1568)

    JavaCompile tasks should now get more build cache hits irrespective of the location of your repo on disk, as `baseline-errorprone` no longer injects an absolute path into `errorproneOptions.excludedPaths`.
    iamdanfox authored Nov 26, 2020
    Copy the full SHA
    252ed9c View commit details
  2. Autorelease 3.57.1

    svc-autorelease committed Nov 26, 2020
    Copy the full SHA
    8b78896 View commit details
  3. Excavator: Upgrade dependencies (#1569)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 26, 2020
    Copy the full SHA
    5ec13f2 View commit details
  4. Excavator: Update conjure plugins and dependencies (#1572)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 26, 2020
    Copy the full SHA
    41d9801 View commit details
  5. Excavator: Update conjure plugins and dependencies (#1573)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 26, 2020
    Copy the full SHA
    c8de883 View commit details

Commits on Nov 27, 2020

  1. Exclude generated sources from error-prone (#1571)

    Exclude generated sources from error-prone
    schlosna authored Nov 27, 2020
    Copy the full SHA
    44682aa View commit details

Commits on Nov 30, 2020

  1. Excavator: Upgrade dependencies (#1575)

    Co-authored-by: svc-excavator-bot <svc-excavator-bot@palantir.com>
    svc-excavator-bot and svc-excavator-bot authored Nov 30, 2020
    Copy the full SHA
    8938dea View commit details
Showing 758 changed files with 26,787 additions and 7,034 deletions.
55 changes: 20 additions & 35 deletions .baseline/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
"https://checkstyle.org/dtds/configuration_1_3.dtd">

<!--
<?xml version="1.0" encoding="UTF-8" standalone="no"?><!--
Palantir Baseline Checkstyle configuration.
Authors: Robert Fink, Brian Worth, Merrick Zoubeiri, and many other contributors. Based in part on http://checkstyle.sourceforge.net/google_style.html
Please keep checks alphabetized with one exception: "relaxed" checks are grouped together at the bottom for easier disabling.
Check-specific comments reference documents internal to Palantir and can be safely ignored or removed.
-->

--><!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" "https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="Checker">
<property name="charset" value="UTF-8"/>
<property name="severity" value="error"/>
@@ -49,7 +43,7 @@
</module>
<module name="LineLength"> <!-- Java Style Guide: No line-wrapping -->
<property name="max" value="120"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://|\{@link"/>
</module>
<module name="TreeWalker">
<module name="SuppressionCommentFilter"/> <!-- baseline-gradle: README.md -->
@@ -69,7 +63,9 @@
<property name="tokens" value="VARIABLE_DEF"/>
<property name="allowSamelineMultipleAnnotations" value="true"/>
</module>
<module name="AnnotationUseStyle"/> <!-- Java Style Guide: Annotations -->
<module name="AnnotationUseStyle"> <!-- Java Style Guide: Annotations -->
<property name="trailingArrayComma" value="ignore"/>
</module>
<module name="ArrayTypeStyle"/> <!-- Java Style Guide: No C-style array declarations -->
<module name="AvoidEscapedUnicodeCharacters"> <!-- Java Style Guide: Non-ASCII characters -->
<property name="allowEscapesForControlCharacters" value="true"/>
@@ -81,14 +77,7 @@
</module>
<module name="AvoidStarImport"/> <!-- Java Style Guide: No wildcard imports -->
<module name="AvoidStaticImport"> <!-- Java Style Guide: No static imports -->
<property name="excludes" value="
com.google.common.base.Preconditions.*,
com.palantir.logsafe.Preconditions.*,
java.util.Collections.*,
java.util.stream.Collectors.*,
org.apache.commons.lang3.Validate.*,
org.assertj.core.api.Assertions.*,
org.mockito.Mockito.*"/>
<property name="excludes" value="com.google.common.base.Preconditions.*, com.palantir.logsafe.Preconditions.*, java.util.Collections.*, java.util.stream.Collectors.*, org.apache.commons.lang3.Validate.*, org.assertj.core.api.Assertions.*, org.mockito.Mockito.*"/>
</module>
<module name="ClassTypeParameterName"> <!-- Java Style Guide: Type variable names -->
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
@@ -138,12 +127,12 @@
<module name="IllegalImport"> <!-- Java Coding Guidelines: Import the canonical package -->
<property name="id" value="BanShadedClasses"/>
<property name="illegalPkgs" value=".*\.(repackaged|shaded|thirdparty)"/>
<property name="regexp" value="true" />
<property name="regexp" value="true"/>
<message key="import.illegal" value="Must not import repackaged classes."/>
</module>
<module name="IllegalImport">
<property name="illegalPkgs" value="^org\.gradle\.(internal|.*\.internal)"/>
<property name="regexp" value="true" />
<property name="regexp" value="true"/>
<message key="import.illegal" value="Do not rely on gradle internal classes as these may change in minor releases - use org.gradle.api versions instead."/>
</module>
<module name="IllegalImport">
@@ -196,7 +185,9 @@
<property name="separated" value="true"/>
<property name="sortStaticImportsAlphabetically" value="true"/>
</module>

<module name="InnerAssignment"/> <!-- Java Coding Guidelines: Inner assignments: Not used -->
<!-- Java Style Guide: Nonempty blocks: K & R style -->
<module name="MemberName"> <!-- Java Style Guide: Non-constant field names -->
<property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
<message key="name.invalidPattern" value="Member name ''{0}'' must match pattern ''{1}''."/>
@@ -237,6 +228,7 @@
<message key="name.invalidPattern" value="Package name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="ParameterAssignment"/> <!-- Java Coding Guidelines: Final variables and parameters -->
<!-- Java Style Guide: Horizontal whitespace -->
<module name="RedundantImport"/> <!-- Java Style Guide: No unused imports -->
<module name="RedundantModifier"/> <!-- Java Coding Guidelines: Avoid redundant modifiers -->
<module name="RegexpSinglelineJava"> <!-- Java Coding Guidelines: Use appropriate assertion methods -->
@@ -352,7 +344,7 @@
</module>
<module name="RegexpSinglelineJava">
<property name="format" value="\bCharset.defaultCharset\("/>
<property name="message" value="Use explicit charset (e.g. StandardCharsets.UTF-8) instead of default."/>
<property name="message" value="Use explicit charset (e.g. StandardCharsets.UTF_8) instead of default."/>
</module>
<module name="RegexpSinglelineJava">
<property name="format" value="\bIOUtils\.toString\("/>
@@ -391,7 +383,7 @@
<module name="SuppressWarnings">
<property name="format" value="serial"/>
</module>
<module name="SuppressWarningsHolder" /> <!-- Required for SuppressWarningsFilter -->
<module name="SuppressWarningsHolder"/> <!-- Required for SuppressWarningsFilter -->
<module name="TypeName"> <!-- Java Style Guide: Class names -->
<message key="name.invalidPattern" value="Type name ''{0}'' must match pattern ''{1}''."/>
</module>
@@ -402,29 +394,22 @@
<module name="UpperEll"/> <!-- Java Style Guide: Numeric Literals -->
<module name="VisibilityModifier"/> <!-- Java Coding Guidelines: Minimize mutability -->
<module name="WhitespaceAfter"/> <!-- Java Style Guide: Horizontal whitespace -->
<module name="WhitespaceAround"> <!-- Java Style Guide: Horizontal whitespace -->
<property name="allowEmptyConstructors" value="true"/>
<property name="allowEmptyMethods" value="true"/>
<property name="allowEmptyTypes" value="true"/>
<property name="allowEmptyLoops" value="true"/>
<property name="allowEmptyLambdas" value="true"/>
<property name="ignoreEnhancedForColon" value="false"/>
<message key="ws.notFollowed" value="WhitespaceAround: ''{0}'' is not followed by whitespace. Empty blocks may only be represented as '{}' when not part of a multi-block statement (4.1.3)"/>
<message key="ws.notPreceded" value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
</module>


<!-- Stricter checks begin: delete some or all of the following for faster prototyping, but please restore before pushing to production. -->

<module name="AtclauseOrder"> <!-- Java Style Guide: At-clauses -->
<property name="tagOrder" value="@param, @return, @throws, @deprecated"/>
<property name="target" value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/>
</module>
<module name="CyclomaticComplexity"/> <!-- Java Coding Guidelines: Reduce Cyclomatic Complexity -->
<module name="CyclomaticComplexity"> <!-- Java Coding Guidelines: Reduce Cyclomatic Complexity -->
<property name="switchBlockAsSingleDecisionPoint" value="true"/>
</module>
<module name="DesignForExtension"> <!-- Java Coding Guidelines: Design for extension -->
<property name="ignoredAnnotations" value="ParameterizedTest, Test, Before, BeforeEach, After, AfterEach, BeforeClass, BeforeAll, AfterClass, AfterAll"/>
</module>
<module name="JavadocMethod"> <!-- Java Style Guide: Where Javadoc is used -->
<property name="scope" value="public"/>
<property name="accessModifiers" value="public"/>
<property name="allowMissingParamTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
<property name="allowedAnnotations" value="Override, Test"/>
@@ -460,4 +445,4 @@

<!-- Stricter checks end -->
</module>
</module>
</module>
3 changes: 0 additions & 3 deletions .baseline/checkstyle/custom-suppressions.xml
Original file line number Diff line number Diff line change
@@ -8,7 +8,4 @@
<suppressions>
<!-- Do not lint class which is mostly copied -->
<suppress files=".*StrictUnusedVariable.java" checks="." />

<!-- We have a special whitelist for AssertJ's assertThat method in test code, but we need it in prod code -->
<suppress files="src/main/java/com/palantir/baseline/refaster" checks="AvoidStaticImport" />
</suppressions>
16 changes: 16 additions & 0 deletions .baseline/idea/intellij-java-palantir-style.xml
Original file line number Diff line number Diff line change
@@ -44,6 +44,22 @@
<package name="" withSubpackages="true" static="false" />
</value>
</option>
<!-- Should be a superset of https://github.com/google/error-prone/blob/c481b3f9c2da112db36ccfcbf64e755261a127ab/core/src/main/java/com/google/errorprone/bugpatterns/BadImport.java#L63 -->
<DO_NOT_IMPORT_INNER>
<CLASS name="Builder" />
<CLASS name="BuilderFactory" />
<CLASS name="Callback" />
<CLASS name="Class" />
<CLASS name="Entry" />
<CLASS name="Enum" />
<CLASS name="Factory" />
<CLASS name="Type" />
<CLASS name="Key" />
<CLASS name="Id" />
<CLASS name="Identifier" />
<CLASS name="Provider" />
<CLASS name="Visitor" />
</DO_NOT_IMPORT_INNER>
</GroovyCodeStyleSettings>
<option name="JD_ALIGN_EXCEPTION_COMMENTS" value="false" />
<option name="JD_ALIGN_PARAM_COMMENTS" value="false" />
2 changes: 2 additions & 0 deletions .circleci/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Mark .circleci/config.yml as generated for github reviews
config.yml linguist-generated=true
Loading