Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of f_id_of_upvalue and f_id_of_local #523

Open
hugomg opened this issue Apr 22, 2022 · 0 comments
Open

Get rid of f_id_of_upvalue and f_id_of_local #523

hugomg opened this issue Apr 22, 2022 · 0 comments

Comments

@hugomg
Copy link
Member

hugomg commented Apr 22, 2022

This information is only necessary in the coder, to decide whether to emit a CallStatic or a CallDyn. Currently, we compute this in the to_ir and then have to accurately update it across all optimization passes. This is easy to get wrong (for example, see #522). A better design might be to compute the information only when we reach the coder. Have an analysis pass that identifies the static calls, based on the use-def chains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant