Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release check fail for older version #9

Open
ogre0403 opened this issue Feb 15, 2022 · 1 comment
Open

release check fail for older version #9

ogre0403 opened this issue Feb 15, 2022 · 1 comment

Comments

@ogre0403
Copy link

ogre0403 commented Feb 15, 2022

Hi,

Thanks for your awesome work for visualizing upgrade path. I've used it to figure out the path from 4.3 -> 4.4 -> 4.5 in the past year. Today, we still use it to find the path for our current older cluster, but I found it fail at release check stage.

[root@740c07a58703 test]# ./ocp4upc.sh 4.5.15
[INFO] Checking prerequisites (curl jq dot)... [OK]
[INFO] Errata provided (4.x.z mode), targeting '4.6' channels for upgrade path generation.
[INFO] Checking if '4.5.15' (amd64) is a valid release... [ERROR]
[INFO] TIP: run the script without parameters to see other available architectures.

I do some work, and found the cause should be that 4.5.15 is not found in release check.
I access the quay.io web page, it should be more 1200 results, but when I use curl to access https://quay.io/api/v1/repository/openshift-release-dev/ocp-release, only 500 results are returned, not all of them.

For my problem, I just comment out the release check function, and every thing works as well like before.

[root@740c07a58703 test]# ./ocp4upc.sh 4.5.15
[INFO] Checking prerequisites (curl jq dot)... [SUCC]
[SUCC]
[INFO] Detected mode '4.x.z', targeting channels '4.6' for upgrade path generation.
[WARN] Skipping channel 'eus-4.6_amd64', version not found.
[INFO] Result exported as 'stable-4.6_4.5.15_amd64_20220215.svg'
[INFO] Result exported as 'fast-4.6_4.5.15_amd64_20220215.svg'

Maybe some paging api should be add to the release check url.

Thanks.

@pamoedom
Copy link
Owner

Hi @ogre0403, first of all, thanks for your comment, it's great to know that someone is still using the tool :)

Please note that I'm no longer developing this script in favor of this official tool, however, you are right, the API endpoint I'm using to check if the release is valid only contain now those versions still supported, but it doesn't mean that previous versions are not valid to generate a correct graph. If we want to allow all of them, we'll need to use different endpoints per architecture and version, there is no single place with all of them like the current one, which complicates the workflow.

One thing I can do is to allow the tool to skip this check when failing, similar to the one I have in place when quay is down, let me double check it, I'll keep you posted if any progress.

Best Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants