private import

Author: MarcoGorelli

pandas_style_guide/_data.py

@@ -5,11 +5,6 @@
 from pandas_style_guide import _plugins
 
 FUNCS = collections.defaultdict(list)
-RECORD_FROM_IMPORTS = frozenset((
-    'numpy',
-    'pytest',
-    'unittest'
-))
 class State(NamedTuple):
     from_imports: Dict[str, Set[str]]
     in_annotation: bool = False
@@ -20,6 +15,11 @@ def register_decorator(func):
         return func
     return register_decorator
 
+def _get_alias(name):
+    if name.asname is not None:
+        return name.asname
+    else:
+        return name.name
 
 def visit(funcs, tree: ast.Module) -> Dict[int, List[int]]:
     "Step through tree, recording when nodes are in annotations."
@@ -35,13 +35,15 @@ def visit(funcs, tree: ast.Module) -> Dict[int, List[int]]:
             yield from ast_func(state, node, parent)
 
         if (
-                isinstance(node, ast.ImportFrom) and
-                not node.level and
-                node.module in RECORD_FROM_IMPORTS
+                isinstance(node, ast.ImportFrom)
+                and node.module is not None
         ):
-            state.from_imports[node.module].update(
-                name.name for name in node.names if not name.asname
+            state.from_imports[node.module.split('.')[0]].update(
+                _get_alias(name) for name in node.names if not name.asname
             )
+        elif isinstance(node, ast.Import):
+            for name in node.names: 
+                state.from_imports[_get_alias(name)]
 
         for name in reversed(node._fields):
             value = getattr(node, name)

pandas_style_guide/_plugins/bare_pytest_raises.py

@@ -5,7 +5,6 @@
 MSG = 'PSG010 bare pytest raises found'
 @register(ast.Call)
 def np_bool_object(state, node, parent):
-    breakpoint()
     if not node.keywords:
         yield node.lineno, node.col_offset, MSG
     elif 'match' not in {keyword.arg for keyword in node.keywords}:

pandas_style_guide/_plugins/private_imports.py

@@ -0,0 +1,15 @@
+import ast
+from pandas_style_guide._data import register
+from pandas_style_guide._ast_helpers import is_name_attr
+
+PRIVATE_FUNCTIONS_ALLOWED = {"sys._getframe"}  # no known alternative
+
+MSG = 'PSG010 private import!'
+@register(ast.Call)
+def np_bool_object(state, node, parent):
+    if isinstance(node.func, ast.Attribute) and isinstance(node.func.value, ast.Name) and (
+        any(node.func.value.id in imports for imports in state.from_imports.values())
+        or   
+        any(node.func.value.id in imports for imports in state.from_imports)
+     ) and node.func.attr.startswith('_'):
+        yield node.lineno, node.col_offset, MSG

t.py

@@ -1,31 +1,5 @@
-# import pytest as foobar
-# from pytest import raises
-# import pytest
-# import numpy as np
-# from unittest import mock
-# import unittest
-# from numpy import bool
+import pandas
+import conftest
+from pandas.foo.bar.dude import _foo
 
-# import numpy as np
-# bool(3)
-with pytest.raises(ValueError, dude='a'):
-    pass
-
-
-pd.api.types.is_scalar
-
-# np.bool
-
-# pytest.raises()
-# raises()
-# filter([123])
-# with pytest.raises:
-#     pass
-
-# exec('123')
-
-# np.testing
-# mock
-# unittest.mock
-foo = 3
-foo.__class__
+_foo._foo('dod')