Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workers] Add in config file a way to set the status #609

Open
Rafiot opened this issue May 30, 2024 · 0 comments
Open

[Workers] Add in config file a way to set the status #609

Rafiot opened this issue May 30, 2024 · 0 comments

Comments

@Rafiot
Copy link
Contributor

Rafiot commented May 30, 2024

The workers set a status while processing a submission and it impacts the final status for the user of the platform. The default levels err on the side of caution, which means we have many false positive. The reason is that if we detect something that could potentially be malicious, we want the user to talk to someone who can help them.

Depending on the environment pandora is used in, the admin may want to ignore some potentially malicious features. It is not recommended and must be used with caution, but we need to have a generic way to disable some warning from the config file.

This is related to #607.

Proposed implementation

  1. Add in every workers config file the type of detection that can be overwritten
  2. Registry of all possible detection that can be raised by a worker (in __init__)
  3. In __init__, the workers get the user-defined status to set for each detection from the config file
  4. Failsafe:
    • warning if a detection is defined in the config but non-existant in the worker / not registered
    • info if a detection is registered in the worker but not in the config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant