Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure #18

Open
ribose-jeffreylau opened this issue Dec 30, 2024 · 4 comments
Open

Compilation failure #18

ribose-jeffreylau opened this issue Dec 30, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ribose-jeffreylau
Copy link
Contributor

Compilation log

Click to download

Environment

$ node --version
v18.19.0
$ yarn --version
3.6.1
$ git rev-parse HEAD
cf7166a62c35ca694dd66d36e9c7e7285d524e3b
@ribose-jeffreylau ribose-jeffreylau added the bug Something isn't working label Dec 30, 2024
@strogonoff
Copy link
Contributor

@ribose-jeffreylau
Copy link
Contributor Author

For sure I didn't.. Thanks for the heads up!

@strogonoff
Copy link
Contributor

strogonoff commented Dec 30, 2024

The build happens independently of TSC. Esbuild does not call TSC.

We should fix TSC, of course. It requires updating the extension package and making sure it works in all cases. In meantime you can rely on IDE tips (my LSP for example for some reason does not have an issue), or scan TSC output for actual errors relevant to your code (slow). And in any case, build and run and test it at runtime.

@strogonoff
Copy link
Contributor

We can keep this bug open anyway in addition to documentation, until we fix this or deprecate this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants