Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing item classes and fields for item classes #24

Open
23 of 24 tasks
ribose-jeffreylau opened this issue Mar 31, 2023 · 2 comments
Open
23 of 24 tasks
Assignees
Labels
bug Something isn't working

Comments

@ribose-jeffreylau
Copy link
Contributor

ribose-jeffreylau commented Mar 31, 2023

@ribose-jeffreylau ribose-jeffreylau added the bug Something isn't working label Mar 31, 2023
@ribose-jeffreylau ribose-jeffreylau self-assigned this Mar 31, 2023
@strogonoff
Copy link
Contributor

strogonoff commented Jun 6, 2023

@ribose-jeffreylau Regarding #26, can you confirm that coordinateSystem should exist on all CRS except Compound? And what did you use as reference to find out these requirements?

Also, I am already seeing vertical & horizontal CRS fields on CompoundCRS in master branch, so perhaps that’s a mistake?

@ribose-jeffreylau
Copy link
Contributor Author

@strogonoff I based all the above requirements from the <form>s as seen in https://geodetic-staging.isotc211.org/register/geodetic/crs -> Propose New.

So, instead of coordinateSystem in Compound, it has instead horizontalCrs and verticalCrs. Notice that:

  • horizontalCrs takes geodeticCrs | projectedCrs | engineeringCrs, whereas
  • verticalCrs takes verticalCrs | engineeringCrs.
Screenshot 2023-06-07 at 13 19 25

@strogonoff strogonoff mentioned this issue Nov 12, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants