Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date precision and false positives in structural diff #6

Open
strogonoff opened this issue Feb 22, 2023 · 0 comments
Open

Date precision and false positives in structural diff #6

strogonoff opened this issue Feb 22, 2023 · 0 comments
Assignees

Comments

@strogonoff
Copy link
Contributor

Here a source item specifies date as a year, edited data specifies item as ISO date, and as a result diff view is confusing:

Screenshot 2023-02-22 at 16 38 03

Screenshot 2023-02-22 at 16 38 14

  • Dates that specify year come from legacy data
  • We mandate full ISO date
  • It’s unclear what to do with dates that specify only year.

To properly address the issue we should use consistent date format:

  • Upconverting them to ISO date. Seems potentially misleading (if it’s unknown on which day in that year the item was actually accepted).
  • Change date format in data spec format to include both a full date and then a precision value that indicates whether month/day matter.

In meantime I want to try fixing structural diff view to show that format has changed (i.e., show original item data without date conversion that happens apparently at some stage).

cc @ribose-jeffreylau

@strogonoff strogonoff self-assigned this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant