Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CR to proposal #24

Open
ribose-jeffreylau opened this issue Mar 30, 2023 · 3 comments
Open

Rename CR to proposal #24

ribose-jeffreylau opened this issue Mar 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ribose-jeffreylau
Copy link

and within a proposal are multiple proposed changes.

Entering a proposal should enable the use to see the list of proposed changes.

Each proposed change comes with a diff and an optional justification.

NOTE: CR is an IEC term that we no longer need to follow.

@ribose-jeffreylau ribose-jeffreylau added the enhancement New feature or request label Mar 30, 2023
@strogonoff
Copy link
Contributor

strogonoff commented Mar 30, 2023

CR should never appear in GUI, if so that is a bug.

(If regarding source code, that is by design for the time being. I considered bulk-renaming units but naming will have to be considered more carefully to avoid confusion between item proposal and proposal umbrella/group and avoid ambiguity like in Java backend where “proposal” stands for either.)

@strogonoff strogonoff removed the enhancement New feature or request label Mar 30, 2023
@ronaldtse
Copy link

The "CR" term is used in the first load screen when entering "proposal mode".

@strogonoff
Copy link
Contributor

The "CR" term is used in the first load screen when entering "proposal mode".

Acknowledged.

@strogonoff strogonoff added the bug Something isn't working label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants