Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images for home page not found #5

Open
ribose-jeffreylau opened this issue Oct 21, 2024 · 2 comments
Open

Images for home page not found #5

ribose-jeffreylau opened this issue Oct 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ribose-jeffreylau
Copy link
Contributor

Example image URLs

@ribose-jeffreylau ribose-jeffreylau added the bug Something isn't working label Oct 21, 2024
@ribose-jeffreylau
Copy link
Contributor Author

This should probably be solved by placing the resources in a specific path inside the passed in --datadir, or as a separate input via a separate CLI parameter.

@ribose-jeffreylau
Copy link
Contributor Author

ribose-jeffreylau commented Jan 9, 2025

With the changes in #9, extra resources can be specified with --injectedresources/-i (one -i param for each file). This is, however, very cumbersome for the typical scenario where assets are organized in a hierarchical file structure, which is not naturally specifiable with --injectedresources as it currently stands.

I'm more inclined to implement a related CLI option that lets one specify directories to include, and site builder would try its best to preserve the path structure, along with a path prefix option (which is typically configurable in web asset bundlers). Maybe something like --injected-assets-dir / -d along with --injected-assets-prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant