Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: switch to python 3.12 #521

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

build: switch to python 3.12 #521

wants to merge 1 commit into from

Conversation

afuetterer
Copy link
Contributor

@afuetterer afuetterer commented Jul 27, 2024 •
edited
Loading

Description

Fixes #516

I don't know why the tests failed before, but there was at least one dependency blocking from moving to Python 3.12.

It seems to be working though. What do you think?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build related changes

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@afuetterer afuetterer marked this pull request as draft July 27, 2024 17:44
@afuetterer afuetterer marked this pull request as ready for review July 27, 2024 17:54
@afuetterer afuetterer marked this pull request as draft July 28, 2024 10:00
@afuetterer
Copy link
Contributor Author

If you choose to accept this, a new fuji version, and a note about switching python versions would be appropriate.

@afuetterer
Copy link
Contributor Author

Maybe there should be a test that builds the docker image in ci and runs some command to verify building is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-investigate usage of Python 3.12
1 participant
@afuetterer