New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul `Preprocessor` methods `get_xyz_file_formats()` #527

Open

afuetterer opened this issue Aug 8, 2024 · 0 comments

Contributor

afuetterer commented Aug 8, 2024 •

edited

Loading

Ref:

Hmm indeed these xy_file_formats methods should be merged into a single method which returns a dictionary with all file formats and a 'preferrence_reason' (logn term, scientific..)
Further, I have seen that the variables which consume these dicts in fair_check.py are still class variables (e.g. cls.SCIENCE_FILE_FORMATS) which I don't like very much.

Originally posted by @huberrob in #480 (comment)

afuetterer mentioned this issue

chore: convert json files to yaml #480

Merged

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment