-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize job names with runner? #185
Comments
This block of code is supposed to be preventing this from happening. So there must be something missing from the logic here: pangeo-forge-runner/pangeo_forge_runner/commands/bake.py Lines 85 to 101 in e2faa93
|
@cisaacstern I think it is 100% working! It raises exactly that error. But what I am proposing is to actually change the jobname within runner so that the error is not raised in the first place. |
Just pinging this again as pretty major useability barrier for out LEAP Data ingestion. I have run into this many times, most recently in https://github.com/leap-stc/eNATL_feedstock/actions/runs/9906590482. I think this is an easily fixable issue that would greatly enhance the user experience with pgf-runner. |
I am running repeatedly into issues with dataflow job names that are not allowed on dataflow like here.
Runner warns about this, but fails. This is acceptable in general but adds avoidable overhead for the maintainer (who often already has a steep learning curve ahead of them). It is also only an issue on Dataflow and thus would be nicely abstracted away on the runner level?
I suggest that we sanitize jobnames within runner in the following way:
_
with-
)The text was updated successfully, but these errors were encountered: