You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, logging is a mix of the original structlog stuff written by @yuvipanda and some click.echo statements I threw in. This is a bit of a mess. Someone needs to dig into this and figure out:
What we need to log
What's the best way to do it
How to integrate click.echo with traditional logging
Since binderbot is designed to be used in CI, good and pretty logging is very important.
The text was updated successfully, but these errors were encountered:
I'm thinking about using https://github.com/jupyter/telemetry/ for logging here. It can provide structured, documented logs that can be easily read by other downstream projects if needed. How does that sound? If it feels too heavyweight, we can just use regular structured logging...
I spent some more time in the binderbot codebase, and have come to different conclusions!
hubtraf's output was primarily for machines, so extreme structure was important. Binderbot's is primarily for humans, so human readability is much more important.
For the most part, detailed timing info or explicit messages about what was currently happening aren't as important as status messages. We should have a debug flag that enables verbose logging, but provide user-readable messages as the primary mechanism.
As such, I think we should remove all non-debug logging anywhere other than from the CLI, and structure our application well enough that we can produce enough useful human output from the cli code.
Right now, logging is a mix of the original structlog stuff written by @yuvipanda and some click.echo statements I threw in. This is a bit of a mess. Someone needs to dig into this and figure out:
Since binderbot is designed to be used in CI, good and pretty logging is very important.
The text was updated successfully, but these errors were encountered: