Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job progress not recorded when using Snakemake version 7.32.0 and above #173

Open
matinnuhamunada opened this issue Nov 20, 2023 · 3 comments

Comments

@matinnuhamunada
Copy link

matinnuhamunada commented Nov 20, 2023

Describe the bug
When upgrading snakemake from version 7.31.1 to 7.32.0, workflow run is recorded, but does not show any progress even though the job is complete. In the example workflow, there should be 14/14 jobs in the workflow, but in snakemake version 7.32.0 it will only shows 0/1

To Reproduce
Steps to reproduce the behavior:

  1. Create conda environment with:
mamba create -c conda-forge -c bioconda -n panoptes_test snakemake==7.32.0 python=3.11 panoptes-ui==0.2.3
mamba activate panoptes_test
  1. Start panoptes
panoptes
  1. Open a new terminal, grab the example workflow
# clone snakemake example workflow
git clone https://github.com/panoptes-organization/snakemake_example_workflow.git
cd snakemake_example_workflow
  1. Run snakemake
mamba activate panoptes_test
bash run_local.sh
  1. See workflow monitor in http://localhost:5000/workflows/ , no jobs were recorded (0/1)
    Picture1

  2. Downgrade snakemake

mamba install snakemake==7.31.1
  1. Run snakemake again
rm -rf results/
bash run_local.sh
  1. See workflow monitor in http://localhost:5000/workflows/ , now 14/14 jobs are recorded
    Picture2

Desktop (please complete the following information):

  • OS: Linux / Ubuntu 22 running on Microsoft Azure VM
  • Browser Chrome
@fgvieira
Copy link
Contributor

I think the only change between those two versions that seems to might have caused this would be snakemake/snakemake#2347.

Could this be related to snakemake/snakemake#2390? Did you try providing --snakefile?

@odcambc
Copy link

odcambc commented Dec 17, 2023

This is fixed in main currently.

Can confirm that snakemake/snakemake#2347 (7fafa7a) breaks job progress - bc854a7 works for me.

It seems like this is working properly as of 0d34be9, but 98d2bdf is the commit that fixes logging.py.

@fgypas
Copy link
Member

fgypas commented Jan 3, 2024

I opened a PR that eliminates the need of passing the snakefile as metadata when the wms-monitor is used: snakemake/snakemake#2573
I tested it with 8.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants