Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When snakemake is manually cancelled the workflow remains as running #99

Open
fgypas opened this issue Nov 9, 2020 · 3 comments
Open
Labels
bug Something isn't working enhancement New feature or request python snakemake

Comments

@fgypas
Copy link
Member

fgypas commented Nov 9, 2020

Describe the bug
When a user manually kills (CTRL+C) a pipeline the process in panoptes stays forever as running

Expected behavior
There are two solutions

  • The server periodically checks for workflows that are not updated (e.g. more than two days) and marks them as Cancellation or Error
  • The ideal solution would be that snakemake sends a signal before the CTRL+C takes place with the message Cancellation. I am not sure if this is possible though.
@fgypas fgypas added bug Something isn't working enhancement New feature or request python snakemake labels Nov 9, 2020
@fgypas fgypas changed the title When snakemake is manually cancelled the workflows remains as running When snakemake is manually cancelled the workflows remain as running Nov 9, 2020
@fgypas fgypas changed the title When snakemake is manually cancelled the workflows remain as running When snakemake is manually cancelled the workflow remains as running Nov 9, 2020
@fgypas fgypas assigned fgypas and unassigned fgypas Nov 9, 2020
@dafentoulis
Copy link
Contributor

How can we reproduce this? @fgypas
For the moment, I'm running the workflow and I kill it with CTRL+C as suggested but the UI turns the workflow's status into "error".

@fgypas
Copy link
Member Author

fgypas commented Dec 11, 2020

I think that @drekoumis added a fix for this at some point. @drekoumis Do you remember the commit/pull request?
This is not completely fixed though, because when you kill the snakemake process with kill (e.g. kill -9 <process-id>) then it gets stack as running on the panoptes side. @dafentoulis Can you try this?

@dafentoulis
Copy link
Contributor

I think that @drekoumis added a fix for this at some point. @drekoumis Do you remember the commit/pull request?
This is not completely fixed though, because when you kill the snakemake process with kill (e.g. kill -9 <process-id>) then it gets stack as running on the panoptes side. @dafentoulis Can you try this?

I managed to reproduce it this way. Thank you. Indeed, manually cancelling with CTRL+C is not a problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request python snakemake
Projects
None yet
Development

No branches or pull requests

2 participants