-
Notifications
You must be signed in to change notification settings - Fork 1
Approve this gem to be made public #1
Comments
|
Thanks for the comments! I just pushed another commit addressing these. Re: the credentials and application name, I think you're right that they should be configurable. Since it's been a while since I've set up the Google OAuth stuff, do you have feedback for what should go in the README here to make setup clearer? I think for now I lean towards keeping Pony config all in the one file. It's definitely bloating a bit with that and Google Calendar stuff but since as far as I'm aware we'll likely only have one non-Panorama user for the near future (who I'll work with to make sure everything gets set up okay) I don't think optimizing the config file is worthwhile right now. Thoughts? |
I think the README is clear enough, re: OAuth. A link to the documentation could be useful, but I imagine the target audience of this will be able to figure all of that out. Just saying you need to get credentials seems sufficient. As for keeping the pony config in one file.. I think thats fine too, so long as its configurable. The changes look good |
Lets make it public! Have you considered writing a blog post about this? |
Awesome, thanks! Just pulled the trigger. :) For the time being (until we get more users and a little more buy-in in general) I think we should hold off on publicizing this, but hopefully in the future we can do a blog post and all that! |
Reviewer, please check that (this is from our usual OSS checklist here):
Tests are reasonable(I don't think this is necessary for this repo.)All code is commented with YARD style(I don't think this is necessary for this repo.)Note: I have confirmed that this code works when following the installation instructions in the README and running the code as a gem built from this code.
Context: We're open-sourcing this because several people have heard about this via word-of-mouth and asked us if they can use it. For the time being, we won't advertise this or blog about it until it has a few more users to iron out the kinks.
The text was updated successfully, but these errors were encountered: