-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test For WordPress Coding Standards #202
Comments
Coding standards are cool, but I am concerned about how many merge conflicts we might cause in downstream repositories if we reformatted wp-config.php. |
There is an increased possibility for merge conflicts the moment anyone edits this file because it does not implicitly follow any coding standard. I routinely add at least four customizations that cannot be done anywhere else. |
Perhaps this issue will morph into creating a |
Yes, Pantheon made a mistake a long time ago and did not set up wp-config.php to be particularly maintainable. The result is that Pantheon users have to modify wp-config.php, so any time we make modifications to it, we risk creating a lot of merge conflicts. Fixing this problem will cause a lot of merge conflicts, but perhaps it will be worth it in the long run. |
wp-config.php
andwp-content/mu-plugins/pantheon
should adhere to WordPress coding standards. An automated test should also run on every pull request.Related: #179
The text was updated successfully, but these errors were encountered: