Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test For WordPress Coding Standards #202

Open
ataylorme opened this issue May 31, 2019 · 4 comments
Open

Test For WordPress Coding Standards #202

ataylorme opened this issue May 31, 2019 · 4 comments

Comments

@ataylorme
Copy link
Contributor

wp-config.php and wp-content/mu-plugins/pantheon should adhere to WordPress coding standards. An automated test should also run on every pull request.

Related: #179

@greg-1-anderson
Copy link
Member

Coding standards are cool, but I am concerned about how many merge conflicts we might cause in downstream repositories if we reformatted wp-config.php.

@dylanjameswagner
Copy link
Contributor

There is an increased possibility for merge conflicts the moment anyone edits this file because it does not implicitly follow any coding standard. I routinely add at least four customizations that cannot be done anywhere else.

@ataylorme
Copy link
Contributor Author

Perhaps this issue will morph into creating a wp-config.pantheon.php and conditionally requiring that from wp-config.php

@greg-1-anderson
Copy link
Member

Yes, Pantheon made a mistake a long time ago and did not set up wp-config.php to be particularly maintainable. The result is that Pantheon users have to modify wp-config.php, so any time we make modifications to it, we risk creating a lot of merge conflicts.

Fixing this problem will cause a lot of merge conflicts, but perhaps it will be worth it in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants