Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decoupled-wordpress-composer-managed] Duplicate keys in composer.json #108

Open
CobyPear opened this issue Jul 19, 2023 · 1 comment
Open

Comments

@CobyPear
Copy link
Member

Hi team! I'm dipping my toes into WordPress land a bit and I noticed some duplicate keys in the composer.json for the decoupled-wordpress-composer-managed

I assume the culprit is here https://github.com/pantheon-systems/wordpress-composer-managed/blob/default/devops/scripts/decoupledpatch.sh#L15 but I'm not really sure the details of these scripts so I would need some guidance to get a fix up.

Thanks!

@jazzsequence
Copy link
Contributor

Oh that's fun.
I think you're right that it's related to the duplication stuff and I don't remember John's reason for that, but I'm sure there was one. I'm wondering if it might be easier to just run composer.json through jq and add to the script to pluck out any duplicates in composer.json via jq. There's probably optimization that could be done in the script as a whole using jq rather than sed, but at the very least I think we could probably add that in without making other, more dramatic changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants