Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example repos to 2.21.0 #20970

Closed
13 tasks done
huonw opened this issue May 29, 2024 · 3 comments
Closed
13 tasks done

Update example repos to 2.21.0 #20970

huonw opened this issue May 29, 2024 · 3 comments

Comments

@sureshjoshi
Copy link
Member

sureshjoshi commented May 29, 2024

Ran my script to knock out a bunch of PRs.

  • codegen doesn't work on my machine (maybe something about thrift? Didn't look into it yet)
  • I don't have go installed on my machine, so that won't work (but I thought we auto-downloaded go binaries, so that's weird - will look into it some day)
  • I don't have docker installed on my daily driver, so can't land that
  • JVM should be fine - but man, coursier is BRUTAL when working with Lulu network blocker - I hate it so much (edit: did this one manually)

@AlexTereshenkov
Copy link
Member

AlexTereshenkov commented Jun 20, 2024

pantsbuild/example-golang#17 is ready for review
pantsbuild/example-docker#18 is ready for review
pantsbuild/example-codegen#27 is ready for review

@AlexTereshenkov
Copy link
Member

All repos are now updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants