Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification hub registration support FCMv1 #772

Open
sdworx-kennydv opened this issue Mar 5, 2024 · 4 comments
Open

Notification hub registration support FCMv1 #772

sdworx-kennydv opened this issue Mar 5, 2024 · 4 comments

Comments

@sdworx-kennydv
Copy link

sdworx-kennydv commented Mar 5, 2024

Hello,

Not sure if this is a bug or more a feature request but very recently a new FCMv1 channel was added for the notification hub and it seems the service explorer is not able to show registrations of this type. I have my own custom tool for some specific operations and when I do a tag search this record is returned (you can ignore PPOI column as this is something based on the tag info):
image
Executing the same tag expression in the explorer doesn't seem to return any results

edit: Here is also a link to the page about the deprecation of the legacy FCM and introduction of FCMv1: link

@ErikMogensen
Copy link
Collaborator

@sdworx-kennydv,

I am happy to see that the Notification hubs team finally released the version with the fix we needed for Service Bus Explorer, on NuGet. The version numbers does not match though... 🤔

The article you linked to says:

Google will deprecate the Firebase Cloud Messaging (FCM) legacy API by July 2024. You can begin migrating from the legacy HTTP protocol to FCM v1 on March 1, 2024. You must complete the migration by June 2024.

Will you or anyone else object if we remove the support for FCM legacy in the next release? If someone needs it, they can use the current release.

I can update SBE to use the new version of the Notification hubs SDK, but I won't be able to test it. Will you be able to verify the release? Perhaps build from source code?

@runtimeErr0r
Copy link

runtimeErr0r commented May 8, 2024

@ErikMogensen I can test the change if you update the source code. I can build it by myself and test it.

@sweetjones95
Copy link

sweetjones95 commented Feb 24, 2025

Hi @ErikMogensen , is there an update on this? I do not see any entries for the FCM v1 for notification hub. Unfortunately, the GCM legacy api is now removed.

@ErikMogensen
Copy link
Collaborator

Okay. When working on this I realized that it would be better if #706 (Save filters per connection) was implemented so I started working on that, but then I had to stop due to moving and downsizing.

I just took a look at the branch and started rebasing main on it. Huge number of merge conflicts 😓. I started but it'll take quite some time just to get back to were it was. I cannot give any timeline nor even state if I am going to go through with this PR.

If you or anyone else want to work on this, just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants