Abstracting EventHubs EventData #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanFeldman
requested review from
paolosalvatori and
ErikMogensen
as code owners
This was referenced Sep 6, 2023
|
@paolosalvatori or @ErikMogensen, could you review/approve? @DelS-AGL was kind enough to give a quick test run and caught one regression that is now fixed. |
paolosalvatori
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #720 #738 #638
A breaking change was introduced in the track 0 SDK
WindowsAzure.ServiceBussomewhere after version6.0.3. As a result of that, it broke SBE ability to clone EventHub messages for UI purposes. This PR is a workaround for the issue to allow rendering EH messages, its custom and system properties, w/o throwing exceptions.2023-09-05_22-11-45.mp4
Disclaimer: I have not tested all the permutations of what can be done with EH. I would appreciate it if someone could take a look to see if there are any undesirable side effects. This is merely an attempt to unblock those who need to be able to list and evaluate messages sent to EH.