Add selective delete to Transfer deadletter subqueues and fix the context menus for the Transfer Deadletter grid view #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikMogensen
requested review from
paolosalvatori and
SeanFeldman
as code owners
sean-feldman-sh
approved these changes
Feb 13, 2024
| public enum SubqueueType | ||
| { | ||
| NotSet, | ||
| NotASubqueue, |
| @@ -115,6 +117,16 @@ public partial class MessageForm : Form | |||
| }; | |||
| #endregion | |||
|
|
|||
| #region Public Enums | |||
| public enum SubqueueType | |||
| stopwatch.Start(); | ||
|
|
||
| if (chkRemove.Checked) | ||
| { | ||
| var messageHandler = CreateDeadLetterMessageHandler(); | ||
|
|
||
| var result = await messageHandler.MoveMessages(messageSender, | ||
| sequenceNumbers, outboundMessages); | ||
| sequenceNumbers, | ||
| transferDLQ: subqueueType == SubqueueType.TransferDeadletter ? true: false, |
There was a problem hiding this comment.
Ternary condition not necessary here.
SeanFeldman
approved these changes
Feb 13, 2024
|
Approved twice, this must be a fantastic PR 😆 |
If I wouldn't approve with the correct account, you'd be blocked 😉 |
I know. I just couldn't resist 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR the context menu when selecting a single Transfer DLQ message looks like this:
and when selecting multiple messages it looks like this:
This PR removes the separate handling of the Transfer Deadletter context menus, they are now the same as for the Deadletter context menus. A lot of the code for handling messages in these subqueues is now shared.
Also added the feature to selectively delete Transfer deadletter messages.
The above is only added for queues and not for subscriptions as the transfer deadletter support is a bit mysterious for subscriptions.