Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chainlink api #309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: chainlink api #309

wants to merge 2 commits into from

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Jan 2, 2023

Signed-off-by: GopherJ [email protected]

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@GopherJ GopherJ requested a review from a team as a code owner January 2, 2023 01:27
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #309 (eacafe2) into main (8afdb27) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   74.88%   74.87%   -0.01%     
==========================================
  Files          82       82              
  Lines        3711     3710       -1     
  Branches      697      697              
==========================================
- Hits         2779     2778       -1     
  Misses        566      566              
  Partials      366      366              
Impacted Files Coverage Δ
contracts/ui/UiIncentiveDataProvider.sol 46.42% <0.00%> (ø)
contracts/misc/ERC721OracleWrapper.sol 26.66% <25.00%> (+1.66%) ⬆️
contracts/ui/UiPoolDataProvider.sol 59.88% <66.66%> (ø)
contracts/misc/ParaSpaceOracle.sol 72.00% <100.00%> (ø)
contracts/misc/UniswapV3OracleWrapper.sol 4.68% <0.00%> (-1.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GopherJ GopherJ changed the title fix: chainlink data not fresh fix: chainlink api Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant