Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show users a better error message for unsupported timestamp ranges #5

Closed
rebasedming opened this issue Mar 9, 2024 · 5 comments
Closed

Comments

@rebasedming
Copy link
Contributor

What
Datafusion only supports queries with timestamps from 1677 to 2262 (https://github.com/apache/arrow-datafusion/blob/b7f477237cc91bbdf90e655db181ca4f0a64fc25/datafusion/functions/src/datetime/common.rs#L34). When users try to query with a timestamp outside of this range i.e. SELECT * FROM t WHERE a < '1650-01-01 01:01:01'::timestamp they get a confusing error message about nanosecond overflow. We should intercept this error message and show them a more helpful one.

Why

How

@Abdi-29
Copy link

Abdi-29 commented Mar 23, 2024

Hi, I'm excited to contribute to paradeDB for the first time.
Before starting, I wanted to check if anyone else is already working on this.
Looking forward to your feedback and suggestions!

@philippemnoel
Copy link
Collaborator

philippemnoel commented Mar 26, 2024

Hi, I'm excited to contribute to paradeDB for the first time. Before starting, I wanted to check if anyone else is already working on this. Looking forward to your feedback and suggestions!

It's all yours! I just assigned you

@philippemnoel philippemnoel transferred this issue from paradedb/paradedb May 9, 2024
@Abdi-29
Copy link

Abdi-29 commented May 10, 2024

I fixed the issue in the arrow-rs and I'm waiting them to accept my pr

@philippemnoel
Copy link
Collaborator

apache/arrow-rs#5730

@philippemnoel
Copy link
Collaborator

Closing these as we're archiving this repository for good

@philippemnoel philippemnoel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants