Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SealedBlock a wrapper of hash + Block #13626

Closed
mattsse opened this issue Jan 3, 2025 · 3 comments · Fixed by #13735
Closed

make SealedBlock a wrapper of hash + Block #13626

mattsse opened this issue Jan 3, 2025 · 3 comments · Fixed by #13735
Assignees
@mattsse
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 3, 2025

Describe the feature

currently SealedBlock has SealedHeader and Body requiring two generics and doesn't allow trait Block usage.

we can now make this equivalent to Sealed<Block>

Additional context

No response
@mattsse mattsse added A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request labels Jan 3, 2025
@mattsse mattsse self-assigned this Jan 3, 2025
@Nanle100
Copy link

Nanle100 commented Jan 3, 2025

can i work on this

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 3, 2025

@Nanle100 there'll be a few more smaller tasks for this, will tag you once I have something smaller

@mattsse mattsse mentioned this issue Jan 3, 2025
Merged
@Nanle100
Copy link

Nanle100 commented Jan 3, 2025

@mattsse Alright. that will be cool

This was referenced Jan 3, 2025
Merged
Closed
Closed
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add SealedBlock in reth-primitives-traits paradigmxyz/reth
2 participants
@mattsse @Nanle100