chore: make SealedBlock.header field private #13646
Open
+169
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jan 4, 2025
yeah, many code change, I have stuck here -> https://github.com/paradigmxyz/reth/pull/13646/files#diff-d46aefacdec3af127f81279bde35fd79e85096a6908f26df1ae2afcb84d1fe68R198 |
Rjected
requested changes
Jan 6, 2025
Comment on lines
61
to
67
|
|
||
| /// Returns a reference to self. | ||
| /// This is useful when you need to convert from a dereferenced header back to SealedHeader. | ||
| #[inline] | ||
| pub const fn as_sealed_header(&self) -> &SealedHeader<H> { | ||
| self | ||
| } |
There was a problem hiding this comment.
This method doesn't seem necessary, since it's just returning self?
| @@ -705,7 +705,7 @@ impl<N: ProviderNodeTypes> HeaderProvider for ConsistentProvider<N> { | |||
| self.get_in_memory_or_storage_by_block_range_while( | |||
| range, | |||
| |db_provider, range, _| db_provider.sealed_headers_range(range), | |||
| |block_state, _| Some(block_state.block_ref().block().header.clone()), | |||
| |block_state, _| Some(block_state.block_ref().block().header().clone()), | |||
There was a problem hiding this comment.
it looks like the deref coercion causes this to call the SealedHeader::header method, which returns an unsealed header. To fix this we could add a method called header_ref to our SealedBlock type, and then clone.
mattsse
requested review from
rakita,
joshieDo,
shekhirin,
onbjerg,
rkrasiuk,
klkvr and
fgimenez
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13640