Remove standalone from_recovered functions and make part of TransactionCompat trait

[mattsse]

Describe the feature

reth/crates/rpc/rpc-types-compat/src/transaction.rs

Lines 15 to 30 in 9b44e2a

	pub fn from_recovered_with_block_context<Tx, T: TransactionCompat<Tx>>(
	tx: RecoveredTx<Tx>,
	tx_info: TransactionInfo,
	resp_builder: &T,
	) -> Result<T::Transaction, T::Error> {
	resp_builder.fill(tx, tx_info)
	}
	/// Create a new rpc transaction result for a _pending_ signed transaction, setting block
	/// environment related fields to `None`.
	pub fn from_recovered<Tx, T: TransactionCompat<Tx>>(
	tx: RecoveredTx<Tx>,
	resp_builder: &T,
	) -> Result<T::Transaction, T::Error> {
	resp_builder.fill(tx, TransactionInfo::default())
	}

from_recovered already just delegates to:

reth/crates/rpc/rpc-types-compat/src/transaction.rs

Lines 50 to 54 in 9b44e2a

	fn fill(
	&self,
	tx: RecoveredTx<T>,
	tx_inf: TransactionInfo,
	) -> Result<Self::Transaction, Self::Error>;

and can easily be removed.

the other one should be introduced as TransactionCompat::fill_pending as a helper

TODO

• introduce TransactionCompat::fill_pending
• remove standalone functions and update calls: flipping from_recovered(transaction, self.tx_resp_builder() to self.tx_resp_builder().fill_pending(transaction) for example

Additional context

No response

[tonypony220]

hi! can i take this?

[mattsse]

assigned, ty

[mymiracle0118]

Could I take on this issue?

[aidenwong812]

I'd be happy to do this.

[PoulavBhowmick03]

Gm gm! I would love to work on this! I have some experience in Rust and have contributed to projects like Starknet Foundry and dojo. This would be my first time contributing to Reth!

[V15HNUPM]

Can I try solving this issue?