Replace RecoveredTx with alloy's RecoveredTx type

[mattsse]

Describe the feature

#13650 unblocks us from phasing out:

reth/crates/primitives/src/transaction/mod.rs

Line 1526 in 81701c2

pub struct RecoveredTx<T = TransactionSigned> {

which is identical to:

https://github.com/alloy-rs/alloy/blob/fa109e3a41bc84ca0721a218003ff3c45dcbc36e/crates/consensus/src/transaction/recovered.rs#L8-L8

there could be a few additional unexpected blockers, the recommended strategy for this pr would be:

0. rename reth_primitives::RecoveredTx functions so that they match alloy::Recovered's (this should be an initial separate PR first)
1. re-export alloy::Recovered as RecoveredTx from reth-primitives-traits
2. remove extension trait and integrate these functions in SignedTransaction directly

   reth/crates/primitives/src/transaction/mod.rs

   Line 1618 in fc9d95a

   pub trait SignedTransactionIntoRecoveredExt: SignedTransaction {

3. uncomment all reth_primitives::RecoveredTx code and replace with a re-export pub use reth_primitives_traits::RecoveredTx
4. see what breaks

possible that we need alloy-rs/alloy#1885 first

Additional context

No response

[bendanzhentan]

Could you please assign this issue to me?

[mattsse]

assigned, ty.

strongly recommend to start with step 0. first to keep overall changes manageable

[V15HNUPM]

I’d like to resolve this.

[bendanzhentan]

Progress:

#13663 does the first step,
#13670 removes reth RecoveredTx and re-exports alloy Recovered.

Very appreciate for your kindly help @mattsse
But there is a remaining sub-task that I have failed to complete. Hope someone can resolve it. Thanks :

remove extension trait and integrate these functions in SignedTransaction directly

reth/crates/primitives/src/transaction/mod.rs

Line 1618 in fc9d95a

pub trait SignedTransactionIntoRecoveredExt: SignedTransaction {

maybe cc @V15HNUPM @mattsse

[mattsse]

remove extension trait and integrate these functions in SignedTransaction directly

this has also been moved already #13677

marking this issue as closed

[V15HNUPM]

is the issue closed

…

On Tue, 7 Jan 2025 at 13:23, Matthias Seitz ***@***.***> wrote: remove extension trait and integrate these functions in SignedTransaction directly this has also been moved already #13677 <#13677> marking this issue as closed — Reply to this email directly, view it on GitHub <#13651 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A5JIEWUD4RGAVH6MKBP6ELT2JOBWZAVCNFSM6AAAAABUTACDAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUGYYDKOBVGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>