discv5 support

[rkrasiuk]

Describe the feature

Integrate https://github.com/sigp/discv5.

Optionally, allow downstreaming invalid messages to other protocol (discv4).
Ref ethereum/go-ethereum#26699

Additional context

TODO

• add Stream wrapper type for the discv5 service that emits events, similar to :

  reth/crates/net/dns/src/lib.rs

  Lines 359 to 366 in 64e3a57

  	/// The converted discovered [Enr] object
  	#[derive(Debug, Clone, Eq, PartialEq)]
  	pub struct DnsNodeRecordUpdate {
  	/// Discovered node and it's addresses
  	pub node_record: NodeRecord,
  	/// The forkid of the node, if present in the ENR
  	pub fork_id: Option<ForkId>,
  	}

• See how Discovery uses the discovery services:

  reth/crates/net/network/src/discovery.rs

  Lines 30 to 35 in 64e3a57

  	/// Handler to interact with the Discovery v4 service
  	discv4: Option<Discv4>,
  	/// All KAD table updates from the discv4 service.
  	discv4_updates: Option<ReceiverStream<DiscoveryUpdate>>,
  	/// The handle to the spawned discv4 service
  	_discv4_service: Option<JoinHandle<()>>,

The way this works is:

• Networkconfig gets discv5 config
• Discovery::new gets the config and spawns service that should emit discovered entries back to Discovery

This discv5 support can be separate crate

Tasks

Beta Give feedback

1. Discv5 support #6151
   A-devp2p A-discv5 A-networking +3
2. feat(discv5): open dns for discv5 #7328
   +0
3. feat(discv5): add crate for interfacing reth network and sigp/discv5 #7336
   A-discv5 A-networking +2
4. feat(discv5): config via cli #7394
   +0
5. feat(discv5): plug discv5 crate into network #7446
   A-networking C-enhancement +2
6. feat(discv5): disable noisy logs #7458
   A-observability +1
7. feat(discv5): Grafana panels #7461
   A-observability +1

[GrapeBaBa]

can I try this?

[PatStiles]

I am game to take this on

[github-actions]

This issue is stale because it has been open for 21 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 7 days since being marked as stale.

[yash-atreya]

@mattsse I can take this

[emhane]

is the fork_id field of the enr how DnsDiscoveryService knows that an enr is EL and not CL? or how else is that being done?

[emhane]

#6151 is syncing base mainnet in 9 hours with --debug.tip flag. pr is being broken down into smaller prs for easier review.